starred/ArchiveBox

Fork 0

mirror of https://github.com/ArchiveBox/ArchiveBox.git synced 2026-04-25 17:16:00 +03:00

[PR #628] [MERGED] fix: Refactor `should_save_extractor` methods to accept `overwrite` parameter #4265

New issue

Closed

opened 2026-03-15 01:35:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 01:35:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/628
Author: @thedanbob
Created: 1/22/2021
Status: ✅ Merged
Merged: 1/22/2021
Merged by: @pirate

Base: dev ← Head: fix-overwrite

📝 Commits (1)

5420903 Refactor should_save_extractor methods to accept overwrite parameter

📊 Changes

14 files changed (+56 additions, -50 deletions)

View changed files

📝 archivebox/extractors/__init__.py (+1 -1)
📝 archivebox/extractors/archive_org.py (+3 -3)
📝 archivebox/extractors/dom.py (+5 -5)
📝 archivebox/extractors/favicon.py (+4 -4)
📝 archivebox/extractors/git.py (+3 -3)
📝 archivebox/extractors/headers.py (+5 -4)
📝 archivebox/extractors/media.py (+3 -4)
📝 archivebox/extractors/mercury.py (+6 -4)
📝 archivebox/extractors/pdf.py (+4 -4)
📝 archivebox/extractors/readability.py (+6 -4)
📝 archivebox/extractors/screenshot.py (+4 -4)
📝 archivebox/extractors/singlefile.py (+6 -4)
📝 archivebox/extractors/title.py (+4 -4)
📝 archivebox/extractors/wget.py (+2 -2)

📄 Description

Summary

Make the --overwrite flag on archivebox add respect user-disabled extractors.

#626

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/628 **Author:** [@thedanbob](https://github.com/thedanbob) **Created:** 1/22/2021 **Status:** ✅ Merged **Merged:** 1/22/2021 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `fix-overwrite` --- ### 📝 Commits (1) - [`5420903`](https://github.com/ArchiveBox/ArchiveBox/commit/5420903102981a49b97c90e61a2f6959fd49614b) Refactor `should_save_extractor` methods to accept `overwrite` parameter ### 📊 Changes **14 files changed** (+56 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/extractors/__init__.py` (+1 -1) 📝 `archivebox/extractors/archive_org.py` (+3 -3) 📝 `archivebox/extractors/dom.py` (+5 -5) 📝 `archivebox/extractors/favicon.py` (+4 -4) 📝 `archivebox/extractors/git.py` (+3 -3) 📝 `archivebox/extractors/headers.py` (+5 -4) 📝 `archivebox/extractors/media.py` (+3 -4) 📝 `archivebox/extractors/mercury.py` (+6 -4) 📝 `archivebox/extractors/pdf.py` (+4 -4) 📝 `archivebox/extractors/readability.py` (+6 -4) 📝 `archivebox/extractors/screenshot.py` (+4 -4) 📝 `archivebox/extractors/singlefile.py` (+6 -4) 📝 `archivebox/extractors/title.py` (+4 -4) 📝 `archivebox/extractors/wget.py` (+2 -2) </details> ### 📄 Description  # Summary Make the --overwrite flag on `archivebox add` respect user-disabled extractors. # Related issues #626 # Changes these areas - [x] Bugfixes - [x] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 01:35:16 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#4265

No description provided.

Rows
Columns

[PR #628] [MERGED] fix: Refactor should_save_extractor methods to accept overwrite parameter #4265