[PR #582] [MERGED] Remove setup django #4251

Closed
opened 2026-03-15 01:34:27 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/582
Author: @cdvv7788
Created: 12/11/2020
Status: Merged
Merged: 12/11/2020
Merged by: @pirate

Base: v0.5.0Head: remove-setup-django


📝 Commits (6)

  • 81d766a refactor: Remove setup_django from title.py
  • a28547c refactor: Remove get_empty_snapshot queryset function and generate it directly
  • e82161a refactor: Remove setup_django from search
  • ce53b02 refactor: Remove setup_django from index
  • 57d1a3d refactor: Remove setup_django from html.py
  • a57a5b6 refactor: call setup_django with the check_db attribute for the commands that actually need the database

📊 Changes

8 files changed (+7 additions, -21 deletions)

View changed files

📝 archivebox/cli/__init__.py (+1 -1)
📝 archivebox/extractors/title.py (+0 -2)
📝 archivebox/index/__init__.py (+2 -9)
📝 archivebox/index/html.py (+0 -2)
📝 archivebox/main.py (+2 -2)
📝 archivebox/search/__init__.py (+1 -2)
📝 archivebox/search/backends/ripgrep.py (+1 -2)
📝 tests/test_oneshot.py (+0 -1)

📄 Description

Summary

Obliterate setup_django from the codebase. It should be called from a single point now.

Changes these areas

  • Bugfixes
  • Feature behavior
  • Command line interface
  • Configuration options
  • Internal architecture
  • Snapshot data layout on disk

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/582 **Author:** [@cdvv7788](https://github.com/cdvv7788) **Created:** 12/11/2020 **Status:** ✅ Merged **Merged:** 12/11/2020 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `v0.5.0` ← **Head:** `remove-setup-django` --- ### 📝 Commits (6) - [`81d766a`](https://github.com/ArchiveBox/ArchiveBox/commit/81d766aba19f201213d7a8853860c0a42f233ef5) refactor: Remove setup_django from title.py - [`a28547c`](https://github.com/ArchiveBox/ArchiveBox/commit/a28547cbcaf4140527586d8d58d80d833da29a21) refactor: Remove get_empty_snapshot queryset function and generate it directly - [`e82161a`](https://github.com/ArchiveBox/ArchiveBox/commit/e82161a768f8c909e175fa836be1225930b56ae1) refactor: Remove setup_django from search - [`ce53b02`](https://github.com/ArchiveBox/ArchiveBox/commit/ce53b0220c12c459c1bb06d95ccc47bd501b5b49) refactor: Remove setup_django from index - [`57d1a3d`](https://github.com/ArchiveBox/ArchiveBox/commit/57d1a3d4e546d2383f23533bd743568a2621ee03) refactor: Remove setup_django from html.py - [`a57a5b6`](https://github.com/ArchiveBox/ArchiveBox/commit/a57a5b6b837770996fb44f2271fcc92872cec636) refactor: call setup_django with the `check_db` attribute for the commands that actually need the database ### 📊 Changes **8 files changed** (+7 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/cli/__init__.py` (+1 -1) 📝 `archivebox/extractors/title.py` (+0 -2) 📝 `archivebox/index/__init__.py` (+2 -9) 📝 `archivebox/index/html.py` (+0 -2) 📝 `archivebox/main.py` (+2 -2) 📝 `archivebox/search/__init__.py` (+1 -2) 📝 `archivebox/search/backends/ripgrep.py` (+1 -2) 📝 `tests/test_oneshot.py` (+0 -1) </details> ### 📄 Description <!-- IMPORTANT: Do not submit PRs with only formatting / PEP8 / line length changes. --> # Summary Obliterate `setup_django` from the codebase. It should be called from a single point now. # Changes these areas - [ ] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [X] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-15 01:34:27 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ArchiveBox#4251
No description provided.