[PR #535] [MERGED] feat: Add extract flag to add command #4226

New issue

Closed

opened 2026-03-15 01:33:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 01:33:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/535
Author: @cdvv7788
Created: 11/13/2020
Status: ✅ Merged
Merged: 11/13/2020
Merged by: @pirate

Base: master ← Head: extractors-flag

📝 Commits (5)

44eede9 feat: Add extract flag to add command
db523c9 fix: Avoid mutable default input argument
1ec8276 fix: Use a comma separated input instead of nargs for the extract flag
54df0a0 fix: Move csv split to the add function to avoid optional nullable argument
257d3f2 Update archivebox/cli/archivebox_add.py

📊 Changes

3 files changed (+31 additions, -6 deletions)

View changed files

📝 archivebox/cli/archivebox_add.py (+9 -1)
📝 archivebox/main.py (+12 -4)
📝 tests/test_add.py (+10 -1)

📄 Description

Summary

The add command now supports the extract flag: archivebox add https://google.com --extract wget singlefile
If there has been something configured using the environment, that will take precedence. We can change this behavior,
but all of the should_use_* methods will need to be changed.

https://github.com/pirate/ArchiveBox/issues/504

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/535 **Author:** [@cdvv7788](https://github.com/cdvv7788) **Created:** 11/13/2020 **Status:** ✅ Merged **Merged:** 11/13/2020 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `master` ← **Head:** `extractors-flag` --- ### 📝 Commits (5) - [`44eede9`](https://github.com/ArchiveBox/ArchiveBox/commit/44eede96e5b75d32758c68a11370ff2a0857b103) feat: Add extract flag to add command - [`db523c9`](https://github.com/ArchiveBox/ArchiveBox/commit/db523c9d828598e0d768a451e4add32c58fdc58f) fix: Avoid mutable default input argument - [`1ec8276`](https://github.com/ArchiveBox/ArchiveBox/commit/1ec82765144fe25f847957a5d37238a0b9cbb8b7) fix: Use a comma separated input instead of nargs for the extract flag - [`54df0a0`](https://github.com/ArchiveBox/ArchiveBox/commit/54df0a035b5fbfea25002b21d6a95de2db1f6fc1) fix: Move csv split to the add function to avoid optional nullable argument - [`257d3f2`](https://github.com/ArchiveBox/ArchiveBox/commit/257d3f2a98b3d36f96f82a9434263b37d99253fb) Update archivebox/cli/archivebox_add.py ### 📊 Changes **3 files changed** (+31 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/cli/archivebox_add.py` (+9 -1) 📝 `archivebox/main.py` (+12 -4) 📝 `tests/test_add.py` (+10 -1) </details> ### 📄 Description # Summary The add command now supports the extract flag: `archivebox add https://google.com --extract wget singlefile` If there has been something configured using the environment, that will take precedence. We can change this behavior, but all of the `should_use_*` methods will need to be changed. # Related issues https://github.com/pirate/ArchiveBox/issues/504 # Changes these areas - [ ] Bugfixes - [X] Feature behavior - [X] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 01:33:06 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#4226

No description provided.

Rows
Columns