mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[PR #525] [MERGED] Move ArchiveResult from detail index.json history to database model #4220
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#4220
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/525
Author: @cdvv7788
Created: 11/3/2020
Status: ✅ Merged
Merged: 11/28/2020
Merged by: @pirate
Base:
master← Head:archive-result📝 Commits (10+)
8f3c03afeat: Initial (and naive) ArchiveResult model309a87efeat: Add extractor field to the databaseb3e0400feat: initial functional version with icons calculated based on archive results4484491feat: Create ArchiveResult after finishing an extractor processf292cfafix: Add condition for oneshot when archiving linksd064a3efix: Handle case when update tries to re-add a link that is not in the sql index33182fdfix: Add missing assignation7165522feat: Add warc to list and limit check to succeeded archive results508a0bbrefactor: Unpack extractors tuple instead of using the index to access the relevant informationf7f0bebfeat: Modify migration reverse function to restore index (WIP)📊 Changes
9 files changed (+180 additions, -40 deletions)
View changed files
📝
archivebox.egg-info/SOURCES.txt(+1 -0)📝
archivebox.egg-info/requires.txt(+1 -1)➕
archivebox/core/migrations/0007_archiveresult.py(+91 -0)📝
archivebox/core/models.py(+23 -0)📝
archivebox/core/utils.py(+45 -30)📝
archivebox/extractors/__init__.py(+13 -0)📝
archivebox/themes/default/base.html(+4 -6)📝
setup.py(+1 -2)📝
tests/test_update.py(+1 -1)📄 Description
Summary
When this PR is ready, archivebox will be able to:
Related issues
https://github.com/pirate/ArchiveBox/issues/513
Changes these areas
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.