[PR #515] [MERGED] Poc setup django on init #4217

New issue

Closed

opened 2026-03-15 01:32:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 01:32:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/515
Author: @cdvv7788
Created: 10/26/2020
Status: ✅ Merged
Merged: 11/28/2020
Merged by: @pirate

Base: master ← Head: POC-setup-django-on-init

📝 Commits (3)

e1d0b8b feat: Initialize django at the beginning
a6bee5f feat: Move setup_django to an inner module
f6ce1de fix: archivebox version was being called as root

📊 Changes

5 files changed (+8 additions, -15 deletions)

View changed files

📝 Dockerfile (+2 -1)
📝 archivebox/cli/__init__.py (+4 -0)
📝 archivebox/index/sql.py (+1 -8)
📝 archivebox/main.py (+0 -5)
📝 tests/fixtures.py (+1 -1)

📄 Description

Summary

Initializing django on cli init, and removing it from internal functions.
The in-memory database may be required at a later point (when we start saving the ArchiveResults to the database) but at this point, this seems to work and no test is broken. Maybe we can remove all of the setup_django calls in this PR and work with that as a basis for the next iteration. WDYT @pirate ?

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/515 **Author:** [@cdvv7788](https://github.com/cdvv7788) **Created:** 10/26/2020 **Status:** ✅ Merged **Merged:** 11/28/2020 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `master` ← **Head:** `POC-setup-django-on-init` --- ### 📝 Commits (3) - [`e1d0b8b`](https://github.com/ArchiveBox/ArchiveBox/commit/e1d0b8bce73c8a919da9915e99a5c51089b0a138) feat: Initialize django at the beginning - [`a6bee5f`](https://github.com/ArchiveBox/ArchiveBox/commit/a6bee5f11100f0fb0901205db5fb646b46777b22) feat: Move setup_django to an inner module - [`f6ce1de`](https://github.com/ArchiveBox/ArchiveBox/commit/f6ce1de8827367997dea32ec6cd691803d3acec5) fix: archivebox version was being called as root ### 📊 Changes **5 files changed** (+8 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+2 -1) 📝 `archivebox/cli/__init__.py` (+4 -0) 📝 `archivebox/index/sql.py` (+1 -8) 📝 `archivebox/main.py` (+0 -5) 📝 `tests/fixtures.py` (+1 -1) </details> ### 📄 Description # Summary Initializing django on cli init, and removing it from internal functions. The in-memory database may be required at a later point (when we start saving the ArchiveResults to the database) but at this point, this seems to work and no test is broken. Maybe we can remove all of the `setup_django` calls in this PR and work with that as a basis for the next iteration. WDYT @pirate ? # Related issues #496 #510 # Changes these areas - [ ] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [X] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 01:32:34 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#4217

No description provided.

Rows
Columns