mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-26 01:26:00 +03:00
[PR #60] [CLOSED] Add config option to ignore bad SSL certs when archiving #4060
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#4060
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/60
Author: @pirate
Created: 1/9/2018
Status: ❌ Closed
Base:
master← Head:ssl-check📝 Commits (2)
57276a7add option to skip ssl validity check249d177Merge branch 'master' into ssl-check📄 Description
In the modern age of HTTPS everywhere, it's becoming increasingly common for sites to set up SSL badly or forget to renew their certificates (especially older 90's era sites), rendering the sites inaccessible.
When browsing I always want to be alerted of bad certs, but when archiving 90% I want it to attempt archiving cites with bad certs anyway in case the content is important. After all, archiving a certificate error page is useless 100% of the time, so instead of throwing out hands up and skipping the site it's nice to at least attempt getting a snapshot.
TODO:
fetch_wgetcli option to skip cert checkfetch_pdfcli option to skip cert checkfetch_screenshotcli option to skip cert checkLast two steps just require doing some research on the chrome headless command line interface to find the right flags.
More Info:
- https://bugs.chromium.org/p/chromium/issues/detail?id=721739
- headless
--ignore-certificate-errors- https://groups.google.com/a/chromium.org/forum/#!topic/headless-dev/eiudRsYdc3A
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.