mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #1530] Bug: Configuration like SAVE_*, USE_CHROME, and YOUTUBEDL_ARGS are inconsistently read on v0.8.5rc3 #3925
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#3925
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nguyenmp on GitHub (Oct 7, 2024).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/1530
Describe the bug
In the old version v0.7.2, I set all my config through the environment variables on my docker container (defined in compose.yaml). I'm trying to upgrade to v0.8.5rc3 and am discovering some very strange behavior.
The easiest one I can define is that
YOUTUBEDL_ARGSno longer seems to work. It seems like, under the hood, we've switched toyt-dlpand the code is now usingYTDLP_EXTRA_ARGS. However, I am unable to set either of these in environment variables OR through the CLI. The command spits out a fat stack trace saying it can't find the right section for this config. I think the problem is that this extractor is now a "plugin" so configuring it is different now?On the other hand, I feel like
USE_CHROMEis completely ignored now and reading through the code, I think that the code was accidentally lost.I tried to switch to SAVE_* variables but they seem to ONLY be read from the
ArchiveBox.conffile which I finally figured out how to set in the CLI:But that leaves me with the question, are environment variables still going to be supported?
Steps to reproduce
Run
docker compose upwith files thatScreenshots or log output
Let me know, happy to add more info here but this seems like a pervasive issue rather than a specific one.
ArchiveBox version
@pirate commented on GitHub (Oct 7, 2024):
The ArchiveBox config command for writing changes to config is not yet implemented in v0.8.5, hang tight I'm still working on it.
Config got a huge overhaul and I haven't matched up all the old aliases yet.
(The code for it wasn't lost it's just been broken out into plugins and changed dramatically)