mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 09:06:02 +03:00
[GH-ISSUE #1508] Feature Request/Bug: Remove external CDN requests jquery/jsdelivr #3909
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#3909
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jessienab on GitHub (Sep 6, 2024).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/1508
Type
What is the problem that your feature request solves
ArchiveBox 0.8.3-rc is making request to two external resources, from the admin panel.
https://code.jquery.com/jquery-3.7.1.slim.min.js
https://cdn.jsdelivr.net/npm/select2@4.1.0-rc.0/dist/js/select2.min.js
Denying access to these resources cause a mild UI rendering issue, see below:


Allowing the resources renders the UI properly:

Possibly related to https://github.com/ArchiveBox/ArchiveBox/issues/644
It would be better to have these files served locally, to both limit external requests, and to provide faster performance. It would also be recommended given that in theory, some users are running ArchiveBox within intranet/local setups.
Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes
Serve the two files locally to reduce external requests and satisfy localhost/intranet/offline users.
What hacks or alternative solutions have you tried to solve the problem?
None, other than blocking the resources with uMatrix.
How badly do you want this new feature?
Thank you very much! :)
@pirate commented on GitHub (Sep 8, 2024):
Sure no problem, I usually remove all external resources I just missed these by accident.
@pirate commented on GitHub (Sep 10, 2024):
Fixed
f5c878b2. Thanks!