mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 09:06:02 +03:00
[GH-ISSUE #1390] Bug: Enter a valid URL. #3864
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#3864
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @raikiriww on GitHub (Mar 27, 2024).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/1390
Describe the bug
I use ArchiveBox(docker image: archivebox/archivebox:dev) to arhivce "http://scz.617.cn:8/body/200004171952.txt". It works but when I try to change the snapshot's Title, it displayed an error message: "Please correct the error below.". I found that the error item is Url: "Enter a valid URL.". But the url is vaild, it is "http://scz.617.cn:8/body/200004171952.txt". I can open it in my browser.
Steps to reproduce
archive "http://scz.617.cn:8/body/200004171952.txt" and change the snapshot's items like "Title" and save.
Screenshots or log output
ArchiveBox version
@raikiriww commented on GitHub (Mar 27, 2024):
I have tested it on my own computer. When Django version is 3.1.14, matching the version in the Docker image, the url "http://scz.617.cn:8/body/200004171952.txt" is considered to be invalid.
Then I discovered that a pull request (PR) had been merged. #1388 So I test it on django-4.2.11 and it passed.
It seems that this issue has already been resolved.
@pirate commented on GitHub (Mar 28, 2024):
Yup, you beat me to it @raikiriww. The newer Django version's URLField should now accept those URLs.
The latest
v0.8.0-rcis currently in alpha testing stage and isn't ready for general use yet, but keep an eye on our releases page to see when it's out! https://github.com/ArchiveBox/ArchiveBox/releases/tag/v0.8.0-rc