mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #1256] Feature Request: Adding an env file with all variables #3789
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#3789
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @marcbria on GitHub (Oct 27, 2023).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/1256
Type
What is the problem that your feature request solves
Adding an
.env.samplefile could help to facilitate the configuration.Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes
Create a sample env file and modify installation instructions to use it.
Existing env variables could be moved to this env file, and you can also add all the existing ones.
Some parameters (ie: ports) could be converted to variables to.
How badly do you want this new feature?
This is my env file, that still need to be extened with vars default values:
@pirate commented on GitHub (Oct 27, 2023):
I don't recommend
.envfiles for persistent config, using./data/ArchiveBox.conforarchivebox config --set ...is what I push users towards as it will be automatically and consistently loaded by any ArchiveBox instances that use that data dir (across all install methods like pip/apt/brew/etc). Compare that to.envwhich is only automatically loaded by Docker or custom shell hooks, which creates confusing situations when a user is running ArchiveBox server in Docker but interacting witharchivebox shell/archivebox list/etc. outside docker and wondering why their config isn't being applied consistently.Of course both methods are supported and documented (even at the same time) and will remain that way, but I'd rather have the ini
.conffile be the canonical default that's recommended for beginners.@marcbria commented on GitHub (Oct 29, 2023):
Interesting approach.
Actually, I really liked the automated installation and configuration process using "docker-compose run".
Thanks for your work. It's impressive.
Cheers,
m.