[GH-ISSUE #981] Enhancement: Add SINGLEFILE_ARGS to pass custom CLI args to singlefile #3628

Closed
opened 2026-03-14 23:47:43 +03:00 by kerem · 4 comments
Owner

Originally created by @renaisun on GitHub (May 23, 2022).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/981

I see there're WGET_ARGS and CURL_ARGS in config.py passed to corresponding binaries. But I don't find a way to customize the options passed to singlefile binary. Is there any way to do so?

Originally created by @renaisun on GitHub (May 23, 2022). Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/981 I see there're `WGET_ARGS` and `CURL_ARGS` in config.py passed to corresponding binaries. But I don't find a way to customize the options passed to singlefile binary. Is there any way to do so?
Author
Owner

@renaisun commented on GitHub (May 24, 2022):

As what I see in singlefile.py, the arguments passed to the executable are --browser-executable-path and --browser-args.
Maybe the only thing to do is to pass all available arguments in single-file? But I have no idea about how to implement it in a programmatic way since the available arguments are based on the version of single-file.

<!-- gh-comment-id:1136087347 --> @renaisun commented on GitHub (May 24, 2022): As what I see in [singlefile.py](https://github.com/ArchiveBox/ArchiveBox/blob/c7370aaebcce03b52b6417736cc202885c79a61c/archivebox/extractors/singlefile.py#L48), the arguments passed to the executable are `--browser-executable-path` and `--browser-args`. Maybe the only thing to do is to pass all available arguments in single-file? But I have no idea about how to implement it in a programmatic way since the available arguments are based on the version of single-file.
Author
Owner

@pirate commented on GitHub (Jun 9, 2022):

Ah sorry looks like we still need to add SINGLEFILE_ARGS and make sure it plays nicely with CHROME_ARGS. This will be a TODO for the next release. Contributors welcome.

Sub-tasks:

<!-- gh-comment-id:1150545982 --> @pirate commented on GitHub (Jun 9, 2022): Ah sorry looks like we still need to add `SINGLEFILE_ARGS` and make sure it plays nicely with `CHROME_ARGS`. This will be a TODO for the next release. Contributors welcome. **Sub-tasks:** - [ ] Add `SINGLEFILE_ARGS` to `archivebox/config.py` - [ ] Import and pass `SINGLEFILE_ARGS` to `archivebox/extractors/singlefile.py` `run()` call - [ ] Document `SINGLEFILE_ARGS` in https://github.com/ArchiveBox/ArchiveBox/wiki/Configuration#dependency-options (and the other `*_ARGS` options while we're at it)
Author
Owner

@renaisun commented on GitHub (Jun 9, 2022):

@pirate Hi, just tried to add the SINGLEFILE_ARGS. Could you please check commit? Also, I've updated the wiki page of *_ARGS

<!-- gh-comment-id:1150845530 --> @renaisun commented on GitHub (Jun 9, 2022): @pirate Hi, just tried to add the `SINGLEFILE_ARGS`. Could you please check [commit](https://github.com/renaisun/ArchiveBox/commit/8899fe0b9259748da2ef19d37028c317f39f37d3)? Also, I've updated the wiki page of `*_ARGS`
Author
Owner

@pirate commented on GitHub (Jan 19, 2024):

Closing as done! https://github.com/ArchiveBox/ArchiveBox/pull/1021 thanks @notevenaperson

<!-- gh-comment-id:1899748160 --> @pirate commented on GitHub (Jan 19, 2024): Closing as done! https://github.com/ArchiveBox/ArchiveBox/pull/1021 thanks @notevenaperson
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ArchiveBox#3628
No description provided.