mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-26 01:26:00 +03:00
[GH-ISSUE #550] Bugfix: Long-running update end up with orphan chromium processes #351
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#351
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mAAdhaTTah on GitHub (Nov 25, 2020).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/550
Describe the bug
I imported my Pocket library, totaling 27k+ links, and have been archiving those links on and off for a week. I went away for a few days, and figured I'd let the process run on my server. When I returned, I found the RAM completely maxed out on the box (16GBs) and dozens of stray Chromium processes still running. ArchiveBox was run in Docker, so I was able to kill the container and reclaim the RAM, rather than needing to kill all of the processes.
My theory is that the timeout doesn't kill the underlying process properly and so it just stayed open, but I'm not 100% sure.
Steps to reproduce
archivebox update.Screenshots or log output
I can pull some logs if needed.
Software versions
@berezovskyi commented on GitHub (Feb 6, 2021):
This does not solve the problem but here is a workaround that I have developed on my system. I have a crontab entry to run this a few times at night:
If you want to update the whole archive, delete the $LOG file.
You should also enable swap limit support: https://docs.docker.com/engine/install/linux-postinstall/#your-kernel-does-not-support-cgroup-swap-limit-capabilities and set CPU/RAM limits.
@pirate commented on GitHub (Apr 6, 2021):
I think I fixed this in
e7c7a8f. Comment back here if you're still seeing issues with orphan child processes after v0.6 is released and I'll reopen the issue.