mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 09:06:02 +03:00
[GH-ISSUE #606] Bugfix: use sandbox in ifrme on archive pages #3396
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#3396
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bash-stack on GitHub (Jan 6, 2021).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/606
when visiting an /index.html of a site using js trackers and ads,
the iframe should be used like described here
e.g.
<iframe src="demo_iframe_sandbox.htm" sandbox></iframe>@pirate commented on GitHub (Jan 6, 2021):
I think this will break a lot of the content being iframed, as lots of content uses plugin features like media/embed/etc. Why not just keep your browser-level adblocker on and let it do the blocking?
What are the concrete benefits of adding this?