mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #228] ArchiveBox incorrectly identifies input source #3176
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#3176
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pigmonkey on GitHub (May 1, 2019).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/228
I always call ArchiveBox with a path to a Pinboard JSON file as an argument.
From the terminal this works fine. However, when this is called by a systemd service (which is executed by a systemd timer), it fails:
The problem is the
if not sys.stdin.isatty()conditional inbin/archivebox. When called via systemd,isatty()will returnFalse, which causes ArchiveBox to assume that it should look tostdinfor input (despite correctly identifying the input argument a few lines previously in theif len(args) == 2:check).There should be another check to see if
stdinis empty.@pirate commented on GitHub (May 1, 2019):
Thanks, this is all refactored in v0.4.0 as well.