mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 09:06:02 +03:00
[GH-ISSUE #445] Bugfix: Archiving process dies when readability extractor falls back to download_url on a URL that's timing out #300
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#300
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mpeteuil on GitHub (Aug 16, 2020).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/445
Describe the bug
The readability extractor attempts to re-use the previous work of the
singlefile,wgetanddomextractors. If there are no files that correspond to the URL for those extractors then it falls back to the download_url method. In cases where this happens and it leads to a timeout the archiving process dies as a result.Steps to reproduce
archivebox addon a URL that will lead to a time out (for example a nonexistent LAN IP,archivebox add "http://192.168.999.999").download_urlfrom utils and this will kill the process due to an uncaught exception. The same thing should happen if only running the readability extractor by itself.Screenshots or log output
Software versions
26022fc@pirate commented on GitHub (Aug 18, 2020):
This should be fixed on the latest version, if you still have any issues comment back here and we'll reopen the ticket.