[PR #1731] Persona system and CHROME_USER_DATA_DIR #2991

New issue

Closed

opened 2026-03-01 18:01:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 18:01:20 +03:00

Owner

Original Pull Request: https://github.com/ArchiveBox/ArchiveBox/pull/1731

State: closed
Merged: Yes

Summary

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

Summary by cubic

Make Chrome launches persona-aware and more reliable by auto-deriving CHROME_USER_DATA_DIR/CHROME_EXTENSIONS_DIR from ACTIVE_PERSONA and adding a Persona class to manage profile data. Also make Chrome args configurable and clean up stale locks to prevent failed launches.

New Features
- Auto-derive CHROME_USER_DATA_DIR, CHROME_EXTENSIONS_DIR, and COOKIES_FILE from ACTIVE_PERSONA (fallback to “Default”).
- New Persona class with per-persona directories, config helpers, and chrome cleanup.
- Chrome launch supports userDataDir and passes --user-data-dir; args now configurable via CHROME_ARGS, CHROME_ARGS_EXTRA, and CHROME_SANDBOX.
Bug Fixes
- Remove stale SingletonLock/SingletonSocket across all persona profiles in chrome_cleanup and killZombieChrome to prevent startup failures.
- Hooks now read CHROME_USER_DATA_DIR and CHROME_EXTENSIONS_DIR from env (derived by get_config), avoiding persona-specific logic in plugins.

^{Written for commit 4285a05d19. Summary will update on new commits.}

**Original Pull Request:** https://github.com/ArchiveBox/ArchiveBox/pull/1731 **State:** closed **Merged:** Yes ---  # Summary  # Related issues  # Changes these areas - [ ] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk  --- ## Summary by cubic Make Chrome launches persona-aware and more reliable by auto-deriving CHROME_USER_DATA_DIR/CHROME_EXTENSIONS_DIR from ACTIVE_PERSONA and adding a Persona class to manage profile data. Also make Chrome args configurable and clean up stale locks to prevent failed launches. - **New Features** - Auto-derive CHROME_USER_DATA_DIR, CHROME_EXTENSIONS_DIR, and COOKIES_FILE from ACTIVE_PERSONA (fallback to “Default”). - New Persona class with per-persona directories, config helpers, and chrome cleanup. - Chrome launch supports userDataDir and passes --user-data-dir; args now configurable via CHROME_ARGS, CHROME_ARGS_EXTRA, and CHROME_SANDBOX. - **Bug Fixes** - Remove stale SingletonLock/SingletonSocket across all persona profiles in chrome_cleanup and killZombieChrome to prevent startup failures. - Hooks now read CHROME_USER_DATA_DIR and CHROME_EXTENSIONS_DIR from env (derived by get_config), avoiding persona-specific logic in plugins. <sup>Written for commit 4285a05d19a8b246fbdcbad2ef66f186ed0b1ed7. Summary will update on new commits.</sup>

kerem

2026-03-01 18:01:20 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#2991

No description provided.

Rows
Columns