mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[PR #1710] Add deno and update yt-dlp #2978
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#2978
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/ArchiveBox/ArchiveBox/pull/1710
State: closed
Merged: No
Summary
yt-dlp now requires a js runtime and suggests deno >=2.0 https://github.com/yt-dlp/yt-dlp/issues/15012
In addition to updating the yt-dlp package there is now also a recommended external javascript blob that needs to be installed. See the yt-dlp wiki for install options. Here, I've added the
[default]dependency group which will also install yt-dlp-ejs containing that blob.This ensures yt-dlp continues to work. I was seeing some intermittent issues with the media extractor before this. I've tested this branch by building a docker image and running it against my archivebox install and confirming that some URLs now archive media properly.
I don't know how often the
yt-dlp-ejspackage will end up needing to be updated which may or may not be an argument in favor of eventually having an option to use the option to run the external js from npm but for now this sticks with baking an immutable docker image.I also wasn't familiar with pdm but to update the pdm lock file I just ran
pdm lockwhich seems to have worked but also updated quite a few other dependencies in that lockfile.Related issues
Changes these areas