[PR #1649] Kill the timer process if it doesn't properly terminate. #2972

Closed
opened 2026-03-01 18:01:17 +03:00 by kerem · 0 comments
Owner

Original Pull Request: https://github.com/ArchiveBox/ArchiveBox/pull/1649

State: closed
Merged: Yes


Summary

This tries to fix the problem described in #1646. I ended up using kill() instead of the solution presented there because it turns out the behavior varied from run to run, and I couldn't get that solution to work consistently. Sending a kill signal was the simplest and most consistent fix. There may be some downsides I'm missing.

Related issues

#1646

Changes these areas

  • Bugfixes
  • Feature behavior
  • Command line interface
  • Configuration options
  • Internal architecture
  • Snapshot data layout on disk
**Original Pull Request:** https://github.com/ArchiveBox/ArchiveBox/pull/1649 **State:** closed **Merged:** Yes --- <!-- IMPORTANT: Do not submit PRs with only formatting / PEP8 / line length changes. --> # Summary This tries to fix the problem described in #1646. I ended up using `kill()` instead of the solution presented there because it turns out the behavior varied from run to run, and I couldn't get that solution to work consistently. Sending a kill signal was the simplest and most consistent fix. There may be some downsides I'm missing. <!--e.g. This PR fixes ABC or adds the ability to do XYZ...--> # Related issues #1646 <!-- e.g. #123 or Roadmap goal # https://github.com/pirate/ArchiveBox/wiki/Roadmap --> # Changes these areas - [x] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk
kerem 2026-03-01 18:01:17 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ArchiveBox#2972
No description provided.