mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #431] links in archives doesn't goto local copy #289
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#289
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Aug 9, 2020).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/431
Describe the bug
when in a archive and i click on a link it sends me to that url example.com/some-cool-thing.php instead of https://example.net/archive/123/example.com/some-cool-thing.php
Steps to reproduce
mkdir archiveBox
docker run -v /srv/archiveBox:/data nikisweeting/archivebox init
docker run -v /srv/archiveBox:/data nikisweeting/archivebox add --depth 1 'https://example.org'
docker run -v /srv/archiveBox:/data -p 8000 nikisweeting/archivebox server 0.0.0.0:8000
then i goto firefox and open the archive
https://example.net/archive/456/example.org/index.html
and click on link
Screenshots or log output
Software versions
git rev-parse HEAD | head -c7[e.g.d798117] commit ID of the version you're running)the newest one from dockerpython3 --version[e.g. 3.7.0])3.6.9chromium-browser --version[e.g. 73.1.2.3] if relevant to bug)i don't use chrome@cdvv7788 commented on GitHub (Aug 9, 2020):
@NavnDK to the right in the admin, there are several icons (one per each extractor used). Are those not working either?
@ghost commented on GitHub (Aug 9, 2020):
i can't even make an account... i have no idea what TTY is in this case
"[i] [2020-08-09 00:43:48] ArchiveBox v0.4.11: archivebox manage createsuperuser < /dev/stdin
> /data
Superuser creation skipped due to not running in a TTY. You can run
manage.py createsuperuserin your project to create one manually."@cdvv7788 commented on GitHub (Aug 9, 2020):
try
docker run -v /srv/archiveBox:/data -p 8000 nikisweeting/archivebox manage createsuperuser@ghost commented on GitHub (Aug 9, 2020):
that is what i did
@pirate commented on GitHub (Aug 10, 2020):
In order to run interactive commands in docker you need to pass
-it, when using docker-compose this is handled automatically and isn't needed.This is the command you want:
Based on this description it sounds like you're expecting links within the archived pages content to be rewritten to the archived equivalents?
If so, I'm afraid this is a wont-fix, I don't intend to rewrite the URLs in the content. If you absolutely need that you should look at
pywbinstead.@pirate commented on GitHub (Aug 10, 2020):
Added a helptext hint for the docker thing:
github.com/pirate/ArchiveBox@33ab7fd4ec (diff-c4c25449ac)