[GH-ISSUE #431] links in archives doesn't goto local copy #289

Closed
opened 2026-03-01 14:42:08 +03:00 by kerem · 6 comments
Owner

Originally created by @ghost on GitHub (Aug 9, 2020).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/431

Describe the bug

when in a archive and i click on a link it sends me to that url example.com/some-cool-thing.php instead of https://example.net/archive/123/example.com/some-cool-thing.php

Steps to reproduce

mkdir archiveBox
docker run -v /srv/archiveBox:/data nikisweeting/archivebox init
docker run -v /srv/archiveBox:/data nikisweeting/archivebox add --depth 1 'https://example.org'
docker run -v /srv/archiveBox:/data -p 8000 nikisweeting/archivebox server 0.0.0.0:8000

then i goto firefox and open the archive
https://example.net/archive/456/example.org/index.html
and click on link

Screenshots or log output

Software versions

  • OS: ([e.g. macOS 10.14] the operating system you're running ArchiveBox on)pop os 18.04
  • ArchiveBox version: (git rev-parse HEAD | head -c7 [e.g. d798117] commit ID of the version you're running)the newest one from docker
  • Python version: (python3 --version [e.g. 3.7.0])3.6.9
  • Chrome version: (chromium-browser --version [e.g. 73.1.2.3] if relevant to bug)i don't use chrome
Originally created by @ghost on GitHub (Aug 9, 2020). Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/431 <!-- Please fill out the following information, feel free to delete sections if they're not applicable or if long issue templates annoy you :) --> #### Describe the bug <!-- A description of what the bug is, what you expected to happen, and any relevant context about issue. --> when in a archive and i click on a link it sends me to that url example.com/some-cool-thing.php instead of https://example.net/archive/123/example.com/some-cool-thing.php #### Steps to reproduce <!-- For example: 1. Ran ArchiveBox with the following config '...' 2. Saw this output during archiving '....' 3. UI didn't show the thing I was expecting '....' --> mkdir archiveBox docker run -v /srv/archiveBox:/data nikisweeting/archivebox init docker run -v /srv/archiveBox:/data nikisweeting/archivebox add --depth 1 'https://example.org' docker run -v /srv/archiveBox:/data -p 8000 nikisweeting/archivebox server 0.0.0.0:8000 then i goto firefox and open the archive https://example.net/archive/456/example.org/index.html and click on link #### Screenshots or log output <!-- If applicable, post any relevant screenshots or copy/pasted terminal output from ArchiveBox. If you're reporting a parsing / importing error, **you must paste a copy of your redacted import file here**. --> #### Software versions - OS: ([e.g. macOS 10.14] the operating system you're running ArchiveBox on)pop os 18.04 - ArchiveBox version: (`git rev-parse HEAD | head -c7` [e.g. d798117] commit ID of the version you're running)the newest one from docker - Python version: (`python3 --version` [e.g. 3.7.0])3.6.9 - Chrome version: (`chromium-browser --version` [e.g. 73.1.2.3] if relevant to bug)i don't use chrome
kerem closed this issue 2026-03-01 14:42:09 +03:00
Author
Owner

@cdvv7788 commented on GitHub (Aug 9, 2020):

@NavnDK to the right in the admin, there are several icons (one per each extractor used). Are those not working either?

<!-- gh-comment-id:670989474 --> @cdvv7788 commented on GitHub (Aug 9, 2020): @NavnDK to the right in the admin, there are several icons (one per each extractor used). Are those not working either?
Author
Owner

@ghost commented on GitHub (Aug 9, 2020):

@NavnDK to the right in the admin, there are several icons (one per each extractor used). Are those not working either?

i can't even make an account... i have no idea what TTY is in this case

"[i] [2020-08-09 00:43:48] ArchiveBox v0.4.11: archivebox manage createsuperuser < /dev/stdin
> /data

Superuser creation skipped due to not running in a TTY. You can run manage.py createsuperuser in your project to create one manually."

<!-- gh-comment-id:670989675 --> @ghost commented on GitHub (Aug 9, 2020): > @NavnDK to the right in the admin, there are several icons (one per each extractor used). Are those not working either? i can't even make an account... i have no idea what TTY is in this case "[i] [2020-08-09 00:43:48] ArchiveBox v0.4.11: archivebox manage createsuperuser < /dev/stdin > /data Superuser creation skipped due to not running in a TTY. You can run `manage.py createsuperuser` in your project to create one manually."
Author
Owner

@cdvv7788 commented on GitHub (Aug 9, 2020):

try docker run -v /srv/archiveBox:/data -p 8000 nikisweeting/archivebox manage createsuperuser

<!-- gh-comment-id:670993544 --> @cdvv7788 commented on GitHub (Aug 9, 2020): try `docker run -v /srv/archiveBox:/data -p 8000 nikisweeting/archivebox manage createsuperuser`
Author
Owner

@ghost commented on GitHub (Aug 9, 2020):

try docker run -v /srv/archiveBox:/data -p 8000 nikisweeting/archivebox manage createsuperuser

that is what i did

<!-- gh-comment-id:670993733 --> @ghost commented on GitHub (Aug 9, 2020): > try `docker run -v /srv/archiveBox:/data -p 8000 nikisweeting/archivebox manage createsuperuser` that is what i did
Author
Owner

@pirate commented on GitHub (Aug 10, 2020):

In order to run interactive commands in docker you need to pass -it, when using docker-compose this is handled automatically and isn't needed.

This is the command you want:

docker run -v /srv/archiveBox:/data -it nikisweeting/archivebox manage createsuperuser

when in a archive and i click on a link it sends me to that url example.com/some-cool-thing.php instead of > https://example.net/archive/123/example.com/some-cool-thing.php

Based on this description it sounds like you're expecting links within the archived pages content to be rewritten to the archived equivalents?

If so, I'm afraid this is a wont-fix, I don't intend to rewrite the URLs in the content. If you absolutely need that you should look at pywb instead.

<!-- gh-comment-id:671142273 --> @pirate commented on GitHub (Aug 10, 2020): In order to run interactive commands in docker you need to pass `-it`, when using docker-compose this is handled automatically and isn't needed. This is the command you want: ```bash docker run -v /srv/archiveBox:/data -it nikisweeting/archivebox manage createsuperuser ``` > when in a archive and i click on a link it sends me to that url example.com/some-cool-thing.php instead of > https://example.net/archive/123/example.com/some-cool-thing.php Based on this description it sounds like you're expecting links within the archived pages content to be rewritten to the archived equivalents? If so, I'm afraid this is a wont-fix, I don't intend to rewrite the URLs in the content. If you absolutely need that you should look at `pywb` instead.
Author
Owner

@pirate commented on GitHub (Aug 10, 2020):

Added a helptext hint for the docker thing: github.com/pirate/ArchiveBox@33ab7fd4ec (diff-c4c25449ac)

<!-- gh-comment-id:671535996 --> @pirate commented on GitHub (Aug 10, 2020): Added a helptext hint for the docker thing: https://github.com/pirate/ArchiveBox/commit/33ab7fd4ec1204c9a917fb04674d43ab6aec304e#diff-c4c25449ac3ca50a6c65236fad6f42deR1063-L1063
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ArchiveBox#289
No description provided.