mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-26 01:26:00 +03:00
[PR #1323] Make "DOCS" link in navigation bar open in new tab #2885
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#2885
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/ArchiveBox/ArchiveBox/pull/1323
State: closed
Merged: Yes
Proposal to have navigation template so DOCS link open in new tab
Summary
I'm working with ArchiveBox for the first time, and looking extensively at the Docs as I do (and enjoying it - thanks!).
I've found it disruptive that the Docs link opens in the same tab: invariably if I want to read docs, I want to do so alongside the application. I realised that this is quite an easy thing to fix by changing the html template, and thought I'd propose it.
Side-note
This is my first pull request, so I'm paranoid that I'm doing it wrong. Please bear that in mind when reviewing.
Changes these areas