[PR #1197] bin_version means to modify, not replace environ #2849

New issue

Closed

opened 2026-03-01 18:00:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 18:00:56 +03:00

Owner

Original Pull Request: https://github.com/ArchiveBox/ArchiveBox/pull/1197

State: closed
Merged: Yes

Summary

The bin_version function means to modify the environment, not replace it entirely. Fixes bugs that occur when it wipes out the PATH environment variable, such as when running in a virtual environment. E.g. results in bin_version not being able to invoke node when it exists on the PATH.

None

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

**Original Pull Request:** https://github.com/ArchiveBox/ArchiveBox/pull/1197 **State:** closed **Merged:** Yes --- # Summary The `bin_version` function means to modify the environment, not replace it entirely. Fixes bugs that occur when it wipes out the PATH environment variable, such as when running in a virtual environment. E.g. results in bin_version not being able to invoke `node` when it exists on the `PATH`.  # Related issues *None*  # Changes these areas - [X] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk

kerem

2026-03-01 18:00:56 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#2849

No description provided.

Rows
Columns