mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #414] Feature Request: If you can't find chrom(e/ium), stop trying to use it #275
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#275
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Jwink3101 on GitHub (Jul 31, 2020).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/414
Type
What is the problem that your feature request solves
At every invocation, including
help, archivebox tells me it can't find chrom(e/ium). This is expected as I do not have it installed (currently using Webfaction. May migrate soon).But when I go to add a page, it throws errors (in stdout, not on the site) and doesn't archive. To fix this, I set
in my invocation script
Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes
Since you already know chromium isn't installed, set those automagically
What hacks or alternative solutions have you tried to solve the problem?
See above
How badly do you want this new feature?
@pirate commented on GitHub (Aug 1, 2020):
@Jwink3101 commented on GitHub (Aug 6, 2020):
It is obviously your prerogative on how to handle this but even
USE_CHROME=Falsedoesn't change the fact that you know you don't have chrome. So it reduces three settings to one but it is still superfluous and causes unexpected errors.(I strongly argue that if the code knows it doesn't have chrome, it shouldn't try and error out)
@cdvv7788 commented on GitHub (Aug 6, 2020):
I think erroring out is a sane default. It is explicit behaviour with a known cause. If you want to avoid using chrome, just tell archivebox to avoid trying to use it.
Implicit (automagical) behaviors can obscure issues, and other users will be left wondering why some of their archiving methods are not working as expected. Also, the
USE_CHROMEflag is explicitly telling archivebox to use chrome...changing this to be moreautomaticwould require a deeper change to deprecate that flag.@pirate commented on GitHub (Aug 6, 2020):
I agree with @cdvv7788 Chrome is such a core part of the ArchiveBox feature set that I'd rather make it extremely noisy unless the user explicitly disables it. Implicit disabling of all the chrome methods would leave many users confused as to why it's silently failing on a large number of the archive methods.