mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 09:06:02 +03:00
[PR #520] [CLOSED] Split Snapshot into Link & Snapshot + migrate #2714
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#2714
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/520
Author: @mAAdhaTTah
Created: 10/30/2020
Status: ❌ Closed
Base:
master← Head:split-snapshot-with-link📝 Commits (1)
429f1deSplit Snapshot into Link & Snapshot + migrate📊 Changes
3 files changed (+96 additions, -10 deletions)
View changed files
📝
archivebox/core/admin.py(+2 -2)➕
archivebox/core/migrations/0007_auto_20201030_1705.py(+60 -0)📝
archivebox/core/models.py(+34 -8)📄 Description
Proof of concept.
Summary
Poking around some ideas to improve the data model in ArchiveBox. This introduces splits the Snapshot into a Snapshot & Link model, with a Link representing a single URL added to ArchiveBox, and a Snapshot representing one download that Link at a given time.
There's definitely more work to be done with this (including testing against more than just one URL + tags), but this seems like one of several necessary steps to move data that's currently on the fs into the db (similar to #513).
How does this approach look? Thoughts?
Related issues
Conversation in #496.
Changes these areas
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.