[PR #459] [MERGED] fix: Add a default cmd #2687

New issue

Closed

opened 2026-03-01 18:00:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 18:00:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/459
Author: @cdvv7788
Created: 8/27/2020
Status: ✅ Merged
Merged: 9/1/2020
Merged by: @pirate

Base: master ← Head: hotfix/#458

📝 Commits (3)

bf3ea42 fix: Add a default cmd value to handle case where the html cannot be retrieved
6603753 feat: Add curl command on readability as default command to debug
a645f36 add comment about fake cmd

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 archivebox/extractors/readability.py (+6 -0)

📄 Description

Summary

When the html cannot be retrieved (timeout, unreachable, etc), the cmd value is not set, which causes archivebox to crash. Adding a default value should be enough in that case.

**Related issues: #458

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Archived data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/459 **Author:** [@cdvv7788](https://github.com/cdvv7788) **Created:** 8/27/2020 **Status:** ✅ Merged **Merged:** 9/1/2020 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `master` ← **Head:** `hotfix/#458` --- ### 📝 Commits (3) - [`bf3ea42`](https://github.com/ArchiveBox/ArchiveBox/commit/bf3ea4214191af5e59d49c49ac683a19905f742d) fix: Add a default cmd value to handle case where the html cannot be retrieved - [`6603753`](https://github.com/ArchiveBox/ArchiveBox/commit/66037535fd5297ffcec7036caa3e7f8f01b0f429) feat: Add curl command on readability as default command to debug - [`a645f36`](https://github.com/ArchiveBox/ArchiveBox/commit/a645f36b87c228c63c609e91a2ac7228dd0b06fb) add comment about fake cmd ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/extractors/readability.py` (+6 -0) </details> ### 📄 Description # Summary When the html cannot be retrieved (timeout, unreachable, etc), the cmd value is not set, which causes archivebox to crash. Adding a default value should be enough in that case. **Related issues: #458 # Changes these areas - [X] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Archived data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 18:00:25 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#2687

No description provided.

Rows
Columns