mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[PR #438] [CLOSED] feat: Check page responsiveness before trying to archive it #2678
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#2678
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/438
Author: @cdvv7788
Created: 8/12/2020
Status: ❌ Closed
Base:
master← Head:hotfix/#209📝 Commits (1)
da14f1cfeat: Check page responsiveness before trying to archive it📊 Changes
3 files changed (+37 additions, -18 deletions)
View changed files
📝
archivebox/extractors/__init__.py(+24 -18)📝
archivebox/util.py(+7 -0)📝
tests/test_extractors.py(+6 -0)📄 Description
Summary
Run a
HEADrequest before trying to archive. Skip archiving and add failed + 1 to stats in the case that the status code is > 400 or there is an exception.**Related issues: #209
Changes these areas
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.