mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[PR #240] [MERGED] Add "prefers-color-scheme: dark" support #2612
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#2612
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/240
Author: @sbrl
Created: 5/14/2019
Status: ✅ Merged
Merged: 5/18/2019
Merged by: @pirate
Base:
master← Head:prefers-color-scheme📝 Commits (1)
3b0236bAdd prefers-color-scheme: dark support📊 Changes
1 file changed (+38 additions, -8 deletions)
View changed files
📝
archivebox/templates/index.html(+38 -8)📄 Description
IMPORTANT: Do not submit PRs with only formatting / PEP8 / line length changes, I will close them with great prejudice. The PEP8 checks I don't follow are intentional. PRs for minor bugfixes, typos, etc are fine.
Summary
Since the prefers-color-scheme is taking off (Firefox + Safari (!) support it already, Chrome support is coming down the pipeline), I thought ArchiveBox could use support for it too.
This PR adds basic support, via liberal
abuse offilter: invert(100%).Changes these areas
index.htmltemplate contents)🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.