[PR #240] [MERGED] Add "prefers-color-scheme: dark" support #2612

Closed
opened 2026-03-01 18:00:08 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/240
Author: @sbrl
Created: 5/14/2019
Status: Merged
Merged: 5/18/2019
Merged by: @pirate

Base: masterHead: prefers-color-scheme


📝 Commits (1)

  • 3b0236b Add prefers-color-scheme: dark support

📊 Changes

1 file changed (+38 additions, -8 deletions)

View changed files

📝 archivebox/templates/index.html (+38 -8)

📄 Description

IMPORTANT: Do not submit PRs with only formatting / PEP8 / line length changes, I will close them with great prejudice. The PEP8 checks I don't follow are intentional. PRs for minor bugfixes, typos, etc are fine.

Summary

Since the prefers-color-scheme is taking off (Firefox + Safari (!) support it already, Chrome support is coming down the pipeline), I thought ArchiveBox could use support for it too.

This PR adds basic support, via liberal abuse of filter: invert(100%).

Changes these areas

  • Bugfixes
  • Feature behavior
  • Command line interface
  • Configuration options
  • Internal architecture
  • Archived data layout on disk (NOTE: Only the index.html template contents)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/240 **Author:** [@sbrl](https://github.com/sbrl) **Created:** 5/14/2019 **Status:** ✅ Merged **Merged:** 5/18/2019 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `master` ← **Head:** `prefers-color-scheme` --- ### 📝 Commits (1) - [`3b0236b`](https://github.com/ArchiveBox/ArchiveBox/commit/3b0236b087defc2e73e8f0301c016ce6efbd0b01) Add prefers-color-scheme: dark support ### 📊 Changes **1 file changed** (+38 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/templates/index.html` (+38 -8) </details> ### 📄 Description **IMPORTANT: Do not submit PRs with only formatting / PEP8 / line length changes, I will close them with great prejudice. The PEP8 checks I don't follow are intentional. PRs for minor bugfixes, typos, etc are fine.** # Summary Since the [prefers-color-scheme](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme) is [taking off](https://caniuse.com/#feat=prefers-color-scheme) (Firefox + Safari (!) support it already, Chrome support is coming down the pipeline), I thought ArchiveBox could use support for it too. This PR adds basic support, via liberal ~~ab~~use of `filter: invert(100%)`. # Changes these areas - [ ] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [x] Archived data layout on disk (NOTE: Only the `index.html` template contents) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 18:00:08 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ArchiveBox#2612
No description provided.