[PR #156] [MERGED] Fix double-download of Chromium binary and backwards symlink in Dockerfile #2585

New issue

Closed

opened 2026-03-01 18:00:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 18:00:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/156
Author: @raman325
Created: 3/2/2019
Status: ✅ Merged
Merged: 3/4/2019
Merged by: @pirate

Base: master ← Head: master

📝 Commits (8)

5b5a602 test skipping Puppeteer's Chromium download
99e4622 Remove redundant linking since repo includes link
8d48b4f Update Dockerfile
3c934c2 Changed CMD point to reference proper target
4917147 Changed command to reference proper target
5a55b95 Updated symlink to correct src and target
5417aba Updated CMD
5bd927f Updated command

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 Dockerfile (+6 -1)

📄 Description

Summary

Added env variable to skip puppeteer's downloading of chromium because the Dockerfile already does that and not skipping it results in an error. Also removed a redundant symlinking step since the repo already includes those links

Changes these areas

Config
Bugfixes
Command line interface
Feature behavior
Internal design
Archived data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/156 **Author:** [@raman325](https://github.com/raman325) **Created:** 3/2/2019 **Status:** ✅ Merged **Merged:** 3/4/2019 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (8) - [`5b5a602`](https://github.com/ArchiveBox/ArchiveBox/commit/5b5a602c8a8753dfe2bd18187083ed00580f58d0) test skipping Puppeteer's Chromium download - [`99e4622`](https://github.com/ArchiveBox/ArchiveBox/commit/99e462218529951bf04fbb9ff4c2be483fd31c92) Remove redundant linking since repo includes link - [`8d48b4f`](https://github.com/ArchiveBox/ArchiveBox/commit/8d48b4f8dfe5ba6946c4e4df208b0a90ee240e8b) Update Dockerfile - [`3c934c2`](https://github.com/ArchiveBox/ArchiveBox/commit/3c934c2708f9561620277d180830ef90dac57b28) Changed CMD point to reference proper target - [`4917147`](https://github.com/ArchiveBox/ArchiveBox/commit/4917147447e97651d88acdf1ad26f6dd533238ef) Changed command to reference proper target - [`5a55b95`](https://github.com/ArchiveBox/ArchiveBox/commit/5a55b9540e1843e9b2a793e4f18cf653d3729bc5) Updated symlink to correct src and target - [`5417aba`](https://github.com/ArchiveBox/ArchiveBox/commit/5417aba1caec051bfa445f89891b95f4f7c5a434) Updated CMD - [`5bd927f`](https://github.com/ArchiveBox/ArchiveBox/commit/5bd927fd66ac9f5cc08dc66a49a2e987817a4b77) Updated command ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+6 -1) </details> ### 📄 Description # Summary Added env variable to skip puppeteer's downloading of chromium because the Dockerfile already does that and not skipping it results in an error. Also removed a redundant symlinking step since the repo already includes those links # Changes these areas - [ ] Config - [x] Bugfixes - [ ] Command line interface - [ ] Feature behavior - [ ] Internal design - [ ] Archived data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 18:00:01 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#2585

No description provided.

Rows
Columns