[PR #114] [MERGED] Add dummy favicon entry so FETCH_FAVICON='False' isn't failing #2578

New issue

Closed

opened 2026-03-01 17:59:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 17:59:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/114
Author: @karlicoss
Created: 11/25/2018
Status: ✅ Merged
Merged: 11/26/2018
Merged by: @pirate

Base: master ← Head: fix-favicon

📝 Commits (1)

b0ffc9c Add dummy favicon entry so FETCH_FAVICON='False' isn't failing

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 archiver/links.py (+4 -0)

📄 Description

Previously you would get

  Traceback (most recent call last):
  File "./../archive", line 184, in <module>
    update_archive(out_dir, links, source=source, resume=resume, append=True)
  File "./../archive", line 108, in update_archive
    archive_links(archive_path, links, source=source, resume=resume)
  File "/L/tmp/bookmark-archiver/archiver/archive_methods.py", line 73, in archive_links
    raise e
  File "/L/tmp/bookmark-archiver/archiver/archive_methods.py", line 57, in archive_links
    archive_link(link_dir, link)
  File "/L/tmp/bookmark-archiver/archiver/archive_methods.py", line 115, in archive_link
    write_link_index(link_dir, link)
  File "/L/tmp/bookmark-archiver/archiver/index.py", line 111, in write_link_index
    write_html_link_index(out_dir, link)
  File "/L/tmp/bookmark-archiver/archiver/index.py", line 152, in write_html_link_index
    'wget': link['latest'].get('wget') or wget_output_path(link),
  File "/usr/lib/python3.6/string.py", line 130, in substitute
    return self.pattern.sub(convert, self.template)
  File "/usr/lib/python3.6/string.py", line 123, in convert
    return str(mapping[named])
KeyError: 'favicon'

because of unmatched $favicon in the HTML template string

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/114 **Author:** [@karlicoss](https://github.com/karlicoss) **Created:** 11/25/2018 **Status:** ✅ Merged **Merged:** 11/26/2018 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `master` ← **Head:** `fix-favicon` --- ### 📝 Commits (1) - [`b0ffc9c`](https://github.com/ArchiveBox/ArchiveBox/commit/b0ffc9c07631644ee91b874ecf1ac0dff1a48701) Add dummy favicon entry so FETCH_FAVICON='False' isn't failing ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `archiver/links.py` (+4 -0) </details> ### 📄 Description Previously you would get ``` Traceback (most recent call last): File "./../archive", line 184, in <module> update_archive(out_dir, links, source=source, resume=resume, append=True) File "./../archive", line 108, in update_archive archive_links(archive_path, links, source=source, resume=resume) File "/L/tmp/bookmark-archiver/archiver/archive_methods.py", line 73, in archive_links raise e File "/L/tmp/bookmark-archiver/archiver/archive_methods.py", line 57, in archive_links archive_link(link_dir, link) File "/L/tmp/bookmark-archiver/archiver/archive_methods.py", line 115, in archive_link write_link_index(link_dir, link) File "/L/tmp/bookmark-archiver/archiver/index.py", line 111, in write_link_index write_html_link_index(out_dir, link) File "/L/tmp/bookmark-archiver/archiver/index.py", line 152, in write_html_link_index 'wget': link['latest'].get('wget') or wget_output_path(link), File "/usr/lib/python3.6/string.py", line 130, in substitute return self.pattern.sub(convert, self.template) File "/usr/lib/python3.6/string.py", line 123, in convert return str(mapping[named]) KeyError: 'favicon' ``` because of unmatched `$favicon` in the HTML template string --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 17:59:59 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#2578

No description provided.

Rows
Columns