mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-26 09:36:01 +03:00
[GH-ISSUE #1589] Support: dev branch not runnable during v0.8.x refactoring work #2460
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#2460
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nguyenmp on GitHub (Nov 10, 2024).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/1589
Originally assigned to: @pirate on GitHub.
Provide a screenshot and describe the bug
When I run
docker build .against a clean clone of ArchiveBox, it fails with:I think abx was installed from source (maybe pip install -e ./abx) but that path doesn't work on my machine. Maybe you're mounting it or something weird?
30cd48c30dis the root cause I think.Steps to reproduce
Logs or errors
ArchiveBox Version
How did you install the version of ArchiveBox you are using?
Docker (or other container system like podman/LXC/Kubernetes or TrueNAS/Cloudron/YunoHost/etc.)
What operating system are you running on?
macOS (including Docker on macOS)
What type of drive are you using to store your ArchiveBox data?
data/is on a local SSD or NVMe drivedata/is on a spinning hard drive or external USB drivedata/is on a network mount (e.g. NFS/SMB/CIFS/etc.)data/is on a FUSE mount (e.g. SSHFS/RClone/S3/B2/OneDrive, etc.)Docker Compose Configuration
ArchiveBox Configuration
@pirate commented on GitHub (Nov 12, 2024):
Yeah sorry I haven't pushed all my WIP code to
devyet, it's under heavy active development right now and I'm changing thousands of lines a day as I hone in on a final design for the new plugin architecture https://docs.monadical.com/s/1BvXxNKwT + https://github.com/ArchiveBox/abx-spec-behaviors.If you're trying to run
devto contribute stuff then hang tight and check back in a bit, otherwise if you're tryingdevbecause you just want to try the new BETA features then I recommend using the latest tagged release instead orv0.8.5rc50https://github.com/ArchiveBox/ArchiveBox/releases@nguyenmp commented on GitHub (Nov 12, 2024):
That makes sense, I'll just pull in whenever there's a release then.
I have a forked version of ArchiveBox with some minor patches to work around some
yt-dlpissues I encountered. Specifically, I run it through a socks5 proxy and use oauth.@elixx commented on GitHub (Dec 17, 2024):
I'm seeing similar issues to this with the current
devbranch, and it looks like requirements.txt has a merge conflict committed, and a bunch of references to a localfile:///Volumes/NVME/Users/squash/Local/Code/archiveboxes/ArchiveBox7/archivebox/pkgs/...path.I have an issue after a server migration where I was running a release at one point, and switched to dev, and then back where I need to manually build an image and adjust some things or get dev running again.
@pirate commented on GitHub (Dec 17, 2024):
Do not run dev, it is not in a runnable state and you are 100% going to lose data because I change models all the time without committing migrations on dev. it's in the middle of major refactoring work.
stick to the tagged releases like 0.8.5rc51 where there are migrations and its designed to be used by people besides me.
Also: https://github.com/ArchiveBox/ArchiveBox/issues/1620#issuecomment-2544593080
@elixx commented on GitHub (Dec 18, 2024):
This doesn't help to resolve my issue at all.
I'd like to point out that the default branch on the main repo page is
dev, and there are a bunch of references in the docs that point to building it.@pirate commented on GitHub (Dec 18, 2024):
Default branch = branch that PR's are based on by default (
devis correct, I don't ever want PRs directly tomain). However, I'm doing a bunch of (once-every-5-years) core refactoring work right now and sodevis not in a runnable state suitable for public contributions. If you want to contribute / do development work please open an issue first and describe what you want to work on so it can be prioritized and triaged first. Once v0.9.0 is out, then I'll be ready to accept drive-by public contributions without prior coordination again, anddevwill be auto-tested with the new CI pipeline to make that process easy.Releases = code that is ready for users to run, there are tagged BETA pre-releases available if you want to test the cutting-edge, or use the stable v0.7.3 if you want something more battle-tested. Attempting to run any untagged code will lead to data loss when you try to upgrade it later as there are no migrations for untagged branches.
I don't want people contributing big changes to dev right now. Contributions in the next month that don't fit into the process I described above are negative utility for me right now because they cause a bunch of extra busywork work to try and shoehorn changes into dev mid-refactor. Open an issue, describe the changes you want, but don't write any code based on
devuntil after v0.9.0 drops. If you cant wait, pay for ArchiveBox consulting and get early access, professional support, and custom new features built at your request.See here more more info too: https://github.com/ArchiveBox/ArchiveBox/issues/1526
@pirate commented on GitHub (Dec 18, 2024):
FYI I removed
requirements.txtentirely.uvis now used for the Docker build.c54b9446