mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #1224] Feature Request: change the default YOUTUBEDL_ARGS #2262
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#2262
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sasasqt on GitHub (Aug 31, 2023).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/1224
Type
What is the problem that your feature request solves
--max-filesize aborts the download after exceeding the size limit, should use "--format=(bv*+ba/b)[filesize<=800m][filesize_approx<=?800m]/(bv*+ba/b)" instead
instead of '--write-sub', '--all-subs', #'--write-auto-subs', use "--write-sub", "--write-auto-sub" instead (remove '--all-subs'), yt-dlp will only download the sub in default/original language
Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes
What hacks or alternative solutions have you tried to solve the problem?
How badly do you want this new feature?
@pirate commented on GitHub (Aug 31, 2023):
fixed, thanks
github.com/ArchiveBox/ArchiveBox@73a5f74d38@sasasqt commented on GitHub (Sep 1, 2023):
sry, the command i mentioned above works with websites that provide media size in the metadata (e.g. youtube).
the part
tries to download the best format less than (exact/approx.) x MB
the part
will download the best format regardless of size if no size information is present.
so --max-filesize arg can be used in conjunction with the --format in case there is no size information is present.
since some media may only provide approximate size in the rare case, sizelimit in --max-filesize needs to be like 1.25x greater than sizelimit in the --format
@pirate commented on GitHub (Sep 1, 2023):
I want it to basically download the best available format available that's under ~800mb in size. E.g. if the video is 8k 120fps but only 4 seconds long, download it in original quality, but if it's 360p you can download hours of footage. Each page has an 800mb storage budget and should try to fill it with the highest quality version that fits. In any error case where metadata is not available or only only 1 version is available, fallback to downloading the original version in full quality. I never want to give up and download nothing if only un-matching versions are available, always fallback to downloading something instead of nothing.
I also want it to download every available subtitle version in all languages eventually, but the priority right now is only the default language (if 409 errors are making it hard to request all the subtitles at once).