mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #1177] Bug: When SAVE_WARC is set to false, the web UI still shows the WARC icon activated even though it leads to nothing #2240
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#2240
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @melyux on GitHub (Jul 12, 2023).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/1177
Describe the bug
When the environment variable SAVE_WARC is set to false, the web UI still shows the WARC icon activated even though it leads to nothing.
Steps to reproduce
Screenshots or log output
In this picture, SAVE_PDF, SAVE_GIT, and SAVE_WARC are all set to false, but only the WARC icon shows up as activated while the other 2 are properly grayed out.

ArchiveBox version
@pirate commented on GitHub (Jan 5, 2024):
The WARC method is sort of a lie as it's not really its own extractor, it's just a parameter added when the wget extractor runs.
For speed reasons (to avoid 100s of filesystem calls to tell if the warc files are present) when viewing the Snapshot list, we assume that if WGET ran then there is a WARC available.
This may change in the future if we switch to a different WARC generation method (e.g. ArchiveWeb.page / browsertrix / pywb), but for now it's expected behavior and I'm unlikely to add a whole caching system or complex workaround just for this edge case.