mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 09:06:02 +03:00
[GH-ISSUE #875] Bug: Unable to delete snapshots via UI button on Safari #2048
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#2048
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dotfrankruan on GitHub (Oct 9, 2021).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/875
I am using archivebox the latest version web client, when I try to delete a snapshot, it always says ‘no actions selected’
How could this happen?
By the way, I am using archivebox on arm64(aarch64) platform
@pirate commented on GitHub (Oct 10, 2021):
Can you screenshot the screen where you click delete
@cdzombak commented on GitHub (Nov 15, 2021):
Also running into this. Screenshot, showing "no actions selected" at the top, since I already tried to delete these:
@pirate commented on GitHub (Nov 16, 2021):
We recently pushed a fix for this. Please upgrade to the
devbranch pre-release version and see if it's still happening https://github.com/ArchiveBox/ArchiveBox#install-and-run-a-specific-github-branch@hrwtech commented on GitHub (Apr 28, 2022):
This is still a problem. Can't delete a snapshot that keeps throwing errors. So I can't even archive past this point now. Great Idea but I have found that I now just have 15gb of data thats mostly unusable because the ui doesn't successfully perform ANY actions.
@pirate commented on GitHub (May 3, 2022):
What browser?
@kennir commented on GitHub (May 20, 2022):
I have the same problem on the Safari, Chrome is ok
@fuomag9 commented on GitHub (Jan 26, 2023):
This is still a problem on safari, chrome is fine
@pirate commented on GitHub (Jan 31, 2023):
That makes sense, Safari often doesn't like how we form-encode the button action + checked row IDs during submission (see related issues below).
Because I'm going to tear out all those buttons and rewrite them in the next
0.70.8 release anyway, I'm going to delay fixing this myself (the buttons are stuck using old Django 3.1 internal templates that are blocking the upgrade to >3.2 https://github.com/ArchiveBox/ArchiveBox/issues/988).I apologize for the inconvenience/delay, those buttons and the 3.1 templates they use have caused a bunch of trouble over the last few years and it's time for them to be rewritten anyway. ArchiveBox development pace is slow, I can't promise this will be fixed soon but I promise it wont be forgotten because I do test big releases on Safari and care about Safari UX still long-term.
In the meantime you should still be able to delete snapshots via the CLI
archivebox remove --helpand other browsers in the UI.Related issues:
If this is critical to you or you feel particularly motivated and want to contribute a quick fix before I get around to the rewrite, I'd be happy to review a PR. You can see how we solved similar Safari action button issues in the past with JS workarounds (in the above issues) for inspiration.
@rmohns commented on GitHub (Sep 1, 2023):
Workaround:
For anyone who comes across this: you can delete one snapshot at a time by going to the Admin listing, click the timestamp of the snapshot you wish to delete. This takes you to the edit screen. Scroll down, the Delete button is in the bottom left corner.
@pirate thank you so much for taking this bug seriously. An awful lot of web developers who didn’t live through the IE6 era have no idea why they should care about anything other than Chrome. Thanks for not being one of them ❤️
@pirate commented on GitHub (Jan 19, 2024):
Sorry I didn't get around to this yet in the v0.7.2 release. Haven't forgotten about it! (PR's welcome if anyone beats me to it)