mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 09:06:02 +03:00
[GH-ISSUE #829] Feature Request: Cookies.txt use for singlefile #2026
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#2026
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TheAnachronism on GitHub (Aug 16, 2021).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/829
Type
What is the problem that your feature request solves
The singlefile CLI supports a cookies.txt file too:
https://github.com/gildas-lormeau/SingleFile/issues/574
Would it be possible to also use this here?
If it's available for wget it should be possible for singlefile too
Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes
Restricted websites can be archived with more then just wget or a configured chrome binary.
What hacks or alternative solutions have you tried to solve the problem?
Speaking about singlefile, only manually using the webextension and then upload it in the correct directory.
How badly do you want this new feature?
@TheAnachronism commented on GitHub (Aug 16, 2021):
I'm not experienced in python at all but have quite a bit of coding experience, so for the start I'll just go through the code and propose the changes here
@TheAnachronism commented on GitHub (Aug 16, 2021):
Alright so I guess this entire thing shouldn't be that hard.
Looking at https://github.com/ArchiveBox/ArchiveBox/blob/dev/archivebox/extractors/wget.py only COOKIES_FILE has to be added to the config imports and cli argument has to added to the cmd object on line 48 in https://github.com/ArchiveBox/ArchiveBox/blob/dev/archivebox/extractors/singlefile.py.
Because this entire thing doesn't seem to big, how fast could this get implemented? (Not really that important but was just wondering)
@pirate commented on GitHub (Aug 19, 2021):
It may have to wait till after I get back from vacation in October / Dec, and even then it's lower priority than some of our pending refactors.
If you PR it then as fast as you want ;) I don't think it would take more than a day to implement, test, and document it.