mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 09:06:02 +03:00
[GH-ISSUE #177] Switch all dependencies to pure python and release ArchiveBox pip package #1632
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#1632
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pirate on GitHub (Mar 14, 2019).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/177
I originally thought moving to Python-only dependencies would be intractable, but after some more research I now realize this is quite straightforward.
apt install curl->pip install requests archivenow(requests docs, archivenow docs)apt install wget->pip install wpull pywb(wpull docs, pywb docs)apt install git->pip install GitPython(docs)apt install youtube-dl->pip install youtube-dl(docs)apt install chromium-browser->pip install pyppeteer(docs)Then we wont need users to install any system dependencies anymore, and we can move to using only
requirements.txtandsetup.pyto install ArchiveBox viapip.@anarcat commented on GitHub (Mar 15, 2019):
awesome, can't wait to see that one fly! :) let me know if you need help testing the stuff or get stuck.
@007 commented on GitHub (Mar 15, 2019):
Anything you're fetching with
curlshould be replaced withwgetor vice versa, and that'll cut down on some dependencies in thepiptranslation.@makew0rld commented on GitHub (Aug 10, 2020):
wpull only officially supports Python 3.4 and 3.5, even now it seems. The most recent commit was in Oct. 2019, and the version on PyPI is still outdated. It's a cool tool, but I would not recommend using it, and it doesn't seem to be well maintained.
If you still want to use it anyway, you can install it from Git, and then use a Python dependency manager to only use Python 3.5 for it, but I would not recommend that.
Git install:
@pirate commented on GitHub (Aug 10, 2020):
Yeah I looked at wpull recently and came to the same conclusion. Wget2 looks more promising than wpull.
I think I'm going to close this issue for now, as we start to expand the suite of archiving methods it's looking more and more like many of them will be node-based. Considering we already support
pip install archiveboxnow to get the bulk of archivebox's functionality, and we offer all the methods out-of-the-box via docker, making everything python-only is no longer a priority.@makew0rld commented on GitHub (Aug 10, 2020):
The other issue I see with this is managing conflicting versions of Python dependencies for these tools. I would personally recommend Poetry for that, as it's popular and I've had great experiences with it, but whatever you choose, I still think is an important step. Apologies if you were already going to do this.
I also don't see the value in replacing
gitwith a Python version.