mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #168] purge fails with import error #1627
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#1627
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ehainry on GitHub (Mar 10, 2019).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/168
Describe the bug
Purge fails with an
ImportError. It tries to importparse_json_link_indexwhich fails.@Mortuus-Medicus commented on GitHub (Mar 24, 2019):
Would it be possible to have a remove button/checkbox on the index.html, and thus you could remove by selecting them through that, it could then direcly remove the website or it could just mark it for when ./archive goes to write to it again, it sees the mark and moves the website.
@mlazana commented on GitHub (Mar 30, 2019):
I'll work on it
@pirate commented on GitHub (Mar 30, 2019):
@Mortuus-Medicus yes that will be added once we have the Django UI pushed. For now that's impossible with static HTML as there's no server that's running to listen for the remove request.
The purge script will be updated in v0.3.0, can you wait until that version is released, or do you need to purge URLs immediately?
@Mortuus-Medicus commented on GitHub (Mar 30, 2019):
@pirate Would it not be possible to achieve the same result with JS? Or is that not robust enough?
@pirate commented on GitHub (Mar 30, 2019):
What do you mean? Client-side JS cannot access the filesystem (no way to store the marked URLs for removal without filesystem access), and we're not adding a node server just for that one feature when Django is almost finished anyway.
@Mortuus-Medicus commented on GitHub (Mar 30, 2019):
I see, then there's no real point in reinventing the wheel if you already have almost finished Django!
(Hmm... Don't know why, but I'm feeling the urge to recreate your program in Go)
@pirate commented on GitHub (Apr 11, 2019):
FYI This is fixed here: https://github.com/pirate/ArchiveBox/wiki/Roadmap#-archivebox-remove
There's a posted example of the new behavior there too ^
You can check it out on the
djangobranch, but don't run it on a big existing archive without backing it up somewhere first!