[PR #1754] [MERGED] Fix: Make SingleFile use SINGLEFILE_CHROME_ARGS with fallback to CHROME_ARGS #1503

Closed
opened 2026-03-01 14:50:03 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1754
Author: @pirate
Created: 1/1/2026
Status: Merged
Merged: 1/1/2026
Merged by: @pirate

Base: devHead: claude/issue-1445-20251229-2236


📝 Commits (1)

  • a101449 Fix: Make SingleFile use SINGLEFILE_CHROME_ARGS with fallback to CHROME_ARGS

📊 Changes

2 files changed (+14 additions, -0 deletions)

View changed files

📝 archivebox/plugins/singlefile/config.json (+7 -0)
📝 archivebox/plugins/singlefile/on_Snapshot__50_singlefile.py (+7 -0)

📄 Description

Fixes #1445

This PR resolves the issue where SingleFile was not respecting Chrome user data directory and other Chrome launch options that work for other Chrome-based extractors (PDF, Screenshot, etc.).

Changes

  • Added SINGLEFILE_CHROME_ARGS config option with fallback to CHROME_ARGS
  • Updated SingleFile extractor to pass Chrome arguments via --browser-args
  • Updated documentation

This ensures SingleFile respects the same Chrome configuration as other Chrome-based extractors.

Generated with Claude Code


Summary by cubic

Makes SingleFile honor Chrome launch options by adding SINGLEFILE_CHROME_ARGS (fallback to CHROME_ARGS) and passing them via --browser-args. Fixes #1445 so user-data-dir and other Chrome settings match behavior of other Chrome-based extractors.

  • Bug Fixes
    • Added SINGLEFILE_CHROME_ARGS config with fallback to CHROME_ARGS.
    • Passed Chrome args to SingleFile using --browser-args (JSON array).
    • Updated extractor docstring to document the new variable.

Written for commit a101449cba. Summary will update on new commits.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/1754 **Author:** [@pirate](https://github.com/pirate) **Created:** 1/1/2026 **Status:** ✅ Merged **Merged:** 1/1/2026 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `claude/issue-1445-20251229-2236` --- ### 📝 Commits (1) - [`a101449`](https://github.com/ArchiveBox/ArchiveBox/commit/a101449cba64aaaa6bb6ed9d678915a16e3e9b67) Fix: Make SingleFile use SINGLEFILE_CHROME_ARGS with fallback to CHROME_ARGS ### 📊 Changes **2 files changed** (+14 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/plugins/singlefile/config.json` (+7 -0) 📝 `archivebox/plugins/singlefile/on_Snapshot__50_singlefile.py` (+7 -0) </details> ### 📄 Description Fixes #1445 This PR resolves the issue where SingleFile was not respecting Chrome user data directory and other Chrome launch options that work for other Chrome-based extractors (PDF, Screenshot, etc.). ## Changes - Added `SINGLEFILE_CHROME_ARGS` config option with fallback to `CHROME_ARGS` - Updated SingleFile extractor to pass Chrome arguments via `--browser-args` - Updated documentation This ensures SingleFile respects the same Chrome configuration as other Chrome-based extractors. Generated with [Claude Code](https://claude.ai/code) <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Makes SingleFile honor Chrome launch options by adding SINGLEFILE_CHROME_ARGS (fallback to CHROME_ARGS) and passing them via --browser-args. Fixes #1445 so user-data-dir and other Chrome settings match behavior of other Chrome-based extractors. - **Bug Fixes** - Added SINGLEFILE_CHROME_ARGS config with fallback to CHROME_ARGS. - Passed Chrome args to SingleFile using --browser-args (JSON array). - Updated extractor docstring to document the new variable. <sup>Written for commit a101449cba64aaaa6bb6ed9d678915a16e3e9b67. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 14:50:03 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ArchiveBox#1503
No description provided.