mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[PR #1754] [MERGED] Fix: Make SingleFile use SINGLEFILE_CHROME_ARGS with fallback to CHROME_ARGS #1503
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#1503
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1754
Author: @pirate
Created: 1/1/2026
Status: ✅ Merged
Merged: 1/1/2026
Merged by: @pirate
Base:
dev← Head:claude/issue-1445-20251229-2236📝 Commits (1)
a101449Fix: Make SingleFile use SINGLEFILE_CHROME_ARGS with fallback to CHROME_ARGS📊 Changes
2 files changed (+14 additions, -0 deletions)
View changed files
📝
archivebox/plugins/singlefile/config.json(+7 -0)📝
archivebox/plugins/singlefile/on_Snapshot__50_singlefile.py(+7 -0)📄 Description
Fixes #1445
This PR resolves the issue where SingleFile was not respecting Chrome user data directory and other Chrome launch options that work for other Chrome-based extractors (PDF, Screenshot, etc.).
Changes
SINGLEFILE_CHROME_ARGSconfig option with fallback toCHROME_ARGS--browser-argsThis ensures SingleFile respects the same Chrome configuration as other Chrome-based extractors.
Generated with Claude Code
Summary by cubic
Makes SingleFile honor Chrome launch options by adding SINGLEFILE_CHROME_ARGS (fallback to CHROME_ARGS) and passing them via --browser-args. Fixes #1445 so user-data-dir and other Chrome settings match behavior of other Chrome-based extractors.
Written for commit
a101449cba. Summary will update on new commits.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.