mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 09:06:02 +03:00
[PR #1450] [CLOSED] papers-dl support #1431
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#1431
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1450
Author: @benmuth
Created: 6/6/2024
Status: ❌ Closed
Base:
dev← Head:papers-dl📝 Commits (10+)
03980dcAdd papers-dl options to configee74e06Add papers-dl extractora8a57dbIntegrate papers-dl24ecae2Merge branch 'dev' into papers-dlb4c7ba0Addget_output_pathfunction to papers_dl39afd59Changepaperstopapers_dl6da7cd7Make papers-dl verbose48004afAdd permission hack for pdf2doic2cb15eMake migrations59ec122Add missing comma📊 Changes
12 files changed (+221 additions, -3 deletions)
View changed files
📝
Dockerfile(+6 -0)📝
archivebox/config.py(+19 -0)📝
archivebox/config_stubs.py(+3 -0)➕
archivebox/core/migrations/0023_alter_archiveresult_extractor.py(+36 -0)➕
archivebox/core/migrations/0027_merge_20240610_1731.py(+14 -0)📝
archivebox/extractors/__init__.py(+2 -0)➕
archivebox/extractors/papers_dl.py(+122 -0)📝
archivebox/index/html.py(+2 -1)📝
archivebox/index/schema.py(+3 -1)📝
archivebox/templates/core/snapshot.html(+11 -0)📝
pyproject.toml(+1 -0)📝
tests/fixtures.py(+2 -1)📄 Description
Summary
This PR adds basic support for the papers-dl extractor for downloading scientific papers.
At this point,
papers-dlonly supports Sci-Hub, but it is planned to support other repositories.Current known issues with
papers-dlinclude performance and reliability. Searching known Sci-Hub aliases for a paper is slow and it occasionally causes timeouts during an ArchiveBox add job. There are also other occasional failures, even when doing a repeat search for a paper you've already found. Potential problems with captchas are also currently unaddressed.papers-dlsupports fetching multiple types of paper identifiers, but I still need to add parsing for those to ArchiveBox. At this moment only URLs work. Extractor functions expectLinks that look like URLs, so I'm not sure how best to pass identifiers like DOI or ISBN to thepapers_dlextractor function.Related issues
#720
Changes these areas
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.