[PR #1333] [MERGED] Text Search and Filters don't work at the same time in the web UI #1316 #1382

New issue

Closed

opened 2026-03-01 14:49:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:49:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1333
Author: @neel-suthar
Created: 1/21/2024
Status: ✅ Merged
Merged: 5/7/2024
Merged by: @pirate

Base: dev ← Head: issue1316

📝 Commits (4)

279883d Text Search and Filters don't work at the same time in the web UI #1316
c6d644b Merge branch 'dev' into issue1316
27d5d1d revert queryset intersection back to union for search results
ef856e8 Merge branch 'dev' into issue1316

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 archivebox/core/mixins.py (+1 -1)

📄 Description

Making sure to return distinct results. Changing set operation to '&' to show the matching results from filters AND search term

Fixes: https://github.com/ArchiveBox/ArchiveBox/issues/1316

Summary

The fix involves adjusting the combination of filter and search results to avoid duplicates. Instead of using the "or" (|) operation, consider using a method that ensures the snapshots appearing in the result set satisfy both the filter conditions and the search term. This adjustment aims to eliminate duplicate entries in the combined result.

Before the fix:

After the fix:

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/1333 **Author:** [@neel-suthar](https://github.com/neel-suthar) **Created:** 1/21/2024 **Status:** ✅ Merged **Merged:** 5/7/2024 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `issue1316` --- ### 📝 Commits (4) - [`279883d`](https://github.com/ArchiveBox/ArchiveBox/commit/279883d6bba11138ce7534a422b6fbcfbf48bf9e) Text Search and Filters don't work at the same time in the web UI #1316 - [`c6d644b`](https://github.com/ArchiveBox/ArchiveBox/commit/c6d644be299ec0ccf68181cc722c661475d69aaf) Merge branch 'dev' into issue1316 - [`27d5d1d`](https://github.com/ArchiveBox/ArchiveBox/commit/27d5d1ddc86b35e9d5a74ffe5a197e9de276a9c9) revert queryset intersection back to union for search results - [`ef856e8`](https://github.com/ArchiveBox/ArchiveBox/commit/ef856e8051f5939b76b166505bb0707d0eee001b) Merge branch 'dev' into issue1316 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/core/mixins.py` (+1 -1) </details> ### 📄 Description Making sure to return distinct results. Changing set operation to '&' to show the matching results from filters AND search term Fixes: https://github.com/ArchiveBox/ArchiveBox/issues/1316 # Summary The fix involves adjusting the combination of filter and search results to avoid duplicates. Instead of using the "or" (|) operation, consider using a method that ensures the snapshots appearing in the result set satisfy both the filter conditions and the search term. This adjustment aims to eliminate duplicate entries in the combined result. Before the fix: ![image](https://github.com/ArchiveBox/ArchiveBox/assets/47631351/5c69e53e-2fcf-457b-bf69-d4b83f23960a) After the fix: ![image](https://github.com/ArchiveBox/ArchiveBox/assets/47631351/2438e933-061e-48aa-9c94-edb6fe791a68) # Changes these areas - [x] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>