[PR #1211] [MERGED] Fix archive_org icon "exists" #1353

New issue

Closed

opened 2026-03-01 14:49:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:49:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1211
Author: @DanielBatteryStapler
Created: 8/16/2023
Status: ✅ Merged
Merged: 8/16/2023
Merged by: @pirate

Base: dev ← Head: DanielBatteryStapler-patch-1

📝 Commits (1)

94dacc4 Fix archive_org icon "exists"

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 archivebox/index/html.py (+1 -1)

📄 Description

Summary

This PR fixes a bug where if you make a snapshot while SAVE_ARCHIVE_DOT_ORG is enabled then the archive_org link will always show as active, despite that being explicitly disabled. This is because of a miscalculation of the "exists" variable which ends up being set to "None" instead of "False". Screenshot included showing this -- it should have class="exists-False" but it's class="exists-None".

I didn't make an issue for this as when I noticed the problem I just fixed it instead of reporting anything.

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

Let me know if there's anything I could do to help get this merged.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/1211 **Author:** [@DanielBatteryStapler](https://github.com/DanielBatteryStapler) **Created:** 8/16/2023 **Status:** ✅ Merged **Merged:** 8/16/2023 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `DanielBatteryStapler-patch-1` --- ### 📝 Commits (1) - [`94dacc4`](https://github.com/ArchiveBox/ArchiveBox/commit/94dacc49c74319047563ed8ba547244e72211bcc) Fix archive_org icon "exists" ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/index/html.py` (+1 -1) </details> ### 📄 Description  # Summary This PR fixes a bug where if you make a snapshot while SAVE_ARCHIVE_DOT_ORG is enabled then the archive_org link will always show as active, despite that being explicitly disabled. This is because of a miscalculation of the "exists" variable which ends up being set to "None" instead of "False". Screenshot included showing this -- it should have class="exists-False" but it's class="exists-None". ![20230815_23h24m43s_grim](https://github.com/ArchiveBox/ArchiveBox/assets/10569817/591b46b5-bb5f-4271-ab6e-dccfbd1bb848) # Related issues I didn't make an issue for this as when I noticed the problem I just fixed it instead of reporting anything. # Changes these areas - [X] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk Let me know if there's anything I could do to help get this merged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 14:49:26 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#1353

No description provided.

Rows
Columns