[PR #1197] [MERGED] bin_version means to modify, not replace environ #1343

New issue

Closed

opened 2026-03-01 14:49:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:49:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1197
Author: @overhacked
Created: 7/31/2023
Status: ✅ Merged
Merged: 8/1/2023
Merged by: @pirate

Base: dev ← Head: bin_version_env_fix

📝 Commits (1)

9d9872d bin_version means to modify, not replace environ

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 archivebox/config.py (+2 -1)

📄 Description

Summary

The bin_version function means to modify the environment, not replace it entirely. Fixes bugs that occur when it wipes out the PATH environment variable, such as when running in a virtual environment. E.g. results in bin_version not being able to invoke node when it exists on the PATH.

None

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/1197 **Author:** [@overhacked](https://github.com/overhacked) **Created:** 7/31/2023 **Status:** ✅ Merged **Merged:** 8/1/2023 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `bin_version_env_fix` --- ### 📝 Commits (1) - [`9d9872d`](https://github.com/ArchiveBox/ArchiveBox/commit/9d9872d32577ea78a89a08a96a7398edccc5f5f0) bin_version means to modify, not replace environ ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/config.py` (+2 -1) </details> ### 📄 Description # Summary The `bin_version` function means to modify the environment, not replace it entirely. Fixes bugs that occur when it wipes out the PATH environment variable, such as when running in a virtual environment. E.g. results in bin_version not being able to invoke `node` when it exists on the `PATH`.  # Related issues *None*  # Changes these areas - [X] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>