mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-26 01:26:00 +03:00
[PR #922] [CLOSED] WIP: Add AppImage workflow #1292
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#1292
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/922
Author: @noctux
Created: 2/3/2022
Status: ❌ Closed
Base:
dev← Head:dev📝 Commits (1)
d88202dAdd AppImage workflow📊 Changes
2 files changed (+120 additions, -0 deletions)
View changed files
➕
.github/workflows/appimage.yml(+76 -0)➕
appimage_dist/archivebox.yml(+44 -0)📄 Description
Summary
As discussed in #916, I see value in a release of ArchiveBox as an AppImage along with the other releases.
Therefore, this commit adds a github workflow for automatically building an AppImage on pushes.
Please consider this PR as work in progress. The AppImage building works, but I'm not 100% sure as to how you wish to exactly integrate this workflow into the repository and how uploading to the releases page works. Currently, the AppImage is uploaded as an artifact of the CI-run to show that working artifacts are produced. Currently, you seem to have factored out all distribution-methods into their own submodules. Should I do the same for the appimage_dist?
Furthermore, I plan to write a short bit of documentation on the specifics of the AppImage (i.e.: what is packaged, what is not, that there is no sandboxing and that other distribution methods are preferred and potentially better supported). I'd probably put that into
docs/Install.md. Does that sound like the correct location?Any other comments/requests/*?
Thanks for your efforts!
Related issues
#916
Changes these areas
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
ConnectionResetError: [Errno 104] Connection resetis thrown when user navigates away while page is still loading #2306ConnectionResetError: [Errno 104] Connection resetis thrown when user navigates away while page is still loading #3816