mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[PR #911] [MERGED] Added TAG_SEPARATOR_PATTERN option for splitting tags #1289
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#1289
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/911
Author: @hannah98
Created: 12/30/2021
Status: ✅ Merged
Merged: 1/11/2022
Merged by: @pirate
Base:
dev← Head:dev📝 Commits (3)
049f88dAdded TAG_SEPARATORS option to supply a regex of characters to use when splitting tagsfc3d2bbrename TAG_SEPARATORS to TAG_SEPARATOR_PATTERN666ab20Update archivebox/config.py📊 Changes
3 files changed (+10 additions, -3 deletions)
View changed files
📝
archivebox/config.py(+1 -0)📝
archivebox/config_stubs.py(+1 -0)📝
archivebox/index/sql.py(+8 -3)📄 Description
Summary
This PR adds the
TAG_SEPARATOR_PATTERNoption. This option is a regex character class that will be used when splitting the tag string.It defaults to
[,]which will split tags on commas. Splitting tags is currently done on commas so this will be backwards compatible and should not introduce breaking changes.Some Examples:
TAG_SEPARATOR_PATTERN="[ ]"TAG_SEPARATOR_PATTERN="[ ,]"TAG_SEPARATOR_PATTERN="[ ,;]"Related issues
#725
Changes these areas
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
archivebox oneshot->archivebox snapshot&archivebox extract, expose atomic subtasks for future job queue system #2303archivebox oneshot->archivebox snapshot&archivebox extract, expose atomic subtasks for future job queue system #3814