[PR #886] [MERGED] Fixes Add button behavior on Safari #1286

New issue

Closed

opened 2026-03-01 14:49:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:49:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/886
Author: @adamwolf
Created: 10/29/2021
Status: ✅ Merged
Merged: 10/31/2021
Merged by: @pirate

Base: dev ← Head: safari-add

📝 Commits (1)

18e1fb0 Fixes Add button behavior on Safari

📊 Changes

1 file changed (+11 additions, -4 deletions)

View changed files

📝 archivebox/templates/core/add.html (+11 -4)

📄 Description

Summary

Previously, when you clicked the Add button in Safari, the page wouldn't change.

It looked like it wasn't doing anything, as noted by @rcarmo (https://github.com/ArchiveBox/ArchiveBox/issues/658#issuecomment-948300055)

I didn't track it down the exact reason why. It may be that Safari didn't like the two opening <h3>s, but I was able to find a bunch of people complaining about Safari being very finicky with innerHTML and actually repainting the page, enough that I decided to try just extending the block hide/show behavior already done with the delay-warning, and it works for me now in both Chrome and Safari.

#658, kinda.

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/886 **Author:** [@adamwolf](https://github.com/adamwolf) **Created:** 10/29/2021 **Status:** ✅ Merged **Merged:** 10/31/2021 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `safari-add` --- ### 📝 Commits (1) - [`18e1fb0`](https://github.com/ArchiveBox/ArchiveBox/commit/18e1fb0d9630ffcf7800c8255b1df98a2ef476ac) Fixes Add button behavior on Safari ### 📊 Changes **1 file changed** (+11 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/templates/core/add.html` (+11 -4) </details> ### 📄 Description # Summary Previously, when you clicked the Add button in Safari, the page wouldn't change. It looked like it wasn't doing anything, as noted by @rcarmo (https://github.com/ArchiveBox/ArchiveBox/issues/658#issuecomment-948300055) I didn't track it down the exact reason why. It may be that Safari didn't like the two opening `<h3>`s, but I was able to find a bunch of people complaining about Safari being very finicky with innerHTML and actually repainting the page, enough that I decided to try just extending the block hide/show behavior already done with the delay-warning, and it works for me now in both Chrome and Safari. # Related issues #658, kinda. # Changes these areas - [x] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>