mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-26 01:26:00 +03:00
[PR #593] [CLOSED] Replace Link with Snapshot (WIP) #1240
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#1240
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/593
Author: @cdvv7788
Created: 12/29/2020
Status: ❌ Closed
Base:
v0.5.0← Head:link-removal📝 Commits (10+)
db446ddrefactor: Initial and dirty refactor to replace link with snapshot. Barely functional add command060ba91refactor: Get archivebox init to run7c6f6a1refactor: Get archivebox init to runae72bffrefactor: wget uses snapshot instead of link4ed90f3refactor: singlefile uses snapshot instead of linka6db50drefactor: screenshot uses snapshot instead of linkd6671ffrefactor: readability uses snapshot instead of linkfedba5drefactor: pdf uses snapshot instead of linka94a29erefactor: mercury uses snapshot instead of link9a1e85erefactor: media uses snapshot instead of link📊 Changes
41 files changed (+766 additions, -640 deletions)
View changed files
📝
archivebox/core/admin.py(+1 -1)➕
archivebox/core/migrations/0008_auto_20201228_1718.py(+18 -0)📝
archivebox/core/models.py(+129 -14)📝
archivebox/core/views.py(+2 -1)📝
archivebox/extractors/__init__.py(+36 -46)📝
archivebox/extractors/archive_org.py(+8 -6)📝
archivebox/extractors/dom.py(+8 -6)📝
archivebox/extractors/favicon.py(+7 -5)📝
archivebox/extractors/git.py(+10 -8)📝
archivebox/extractors/headers.py(+9 -7)📝
archivebox/extractors/media.py(+8 -6)📝
archivebox/extractors/mercury.py(+10 -8)📝
archivebox/extractors/pdf.py(+8 -6)📝
archivebox/extractors/readability.py(+13 -11)📝
archivebox/extractors/screenshot.py(+8 -6)📝
archivebox/extractors/singlefile.py(+9 -7)📝
archivebox/extractors/title.py(+13 -10)📝
archivebox/extractors/wget.py(+16 -14)📝
archivebox/index/__init__.py(+135 -170)📝
archivebox/index/csv.py(+5 -3)...and 21 more files
📄 Description
Summary
Use Snapshot everywhere, instead of the old Link schema. This is a work in progress, and most likely unstable at this point.
Changes these areas
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.