[PR #571] [MERGED] Remove walrus operator from the codebase #1232

New issue

Closed

opened 2026-03-01 14:48:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:48:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/571
Author: @cdvv7788
Created: 12/6/2020
Status: ✅ Merged
Merged: 12/6/2020
Merged by: @pirate

Base: v0.5.0 ← Head: remove-walrus

📝 Commits (2)

8d22ebf feat: Remove walrus operator (we still need to support python3.7)
db73d92 docs: Update shell message to import models

📊 Changes

4 files changed (+9 additions, -3 deletions)

View changed files

📝 archivebox/core/models.py (+4 -0)
📝 archivebox/logging_util.py (+1 -1)
📝 archivebox/search/__init__.py (+2 -1)
📝 archivebox/search/backends/ripgrep.py (+2 -1)

📄 Description

Summary

Tests on python3.7 were raising syntax errors.

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/571 **Author:** [@cdvv7788](https://github.com/cdvv7788) **Created:** 12/6/2020 **Status:** ✅ Merged **Merged:** 12/6/2020 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `v0.5.0` ← **Head:** `remove-walrus` --- ### 📝 Commits (2) - [`8d22ebf`](https://github.com/ArchiveBox/ArchiveBox/commit/8d22ebf98810d553c46e692eb65b54837aacaa78) feat: Remove walrus operator (we still need to support python3.7) - [`db73d92`](https://github.com/ArchiveBox/ArchiveBox/commit/db73d92f838695141b405f7cd74b51d56d5b1459) docs: Update shell message to import models ### 📊 Changes **4 files changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/core/models.py` (+4 -0) 📝 `archivebox/logging_util.py` (+1 -1) 📝 `archivebox/search/__init__.py` (+2 -1) 📝 `archivebox/search/backends/ripgrep.py` (+2 -1) </details> ### 📄 Description  # Summary Tests on python3.7 were raising syntax errors. # Changes these areas - [X] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>