mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 09:06:02 +03:00
[GH-ISSUE #176] Index: Link index recursively shows itself inside the iframe #123
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#123
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @danmed on GitHub (Mar 14, 2019).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/176
I've just installed and got this working, but have a weird bug.
The first page i archived worked great.. i go to the index page and then click on the text link and it takes me to a nice HTML representation of the page...
Any subsequent links i archive, the text link takes me to the "Link Index" page, but in the iframe underneath is another copy of the same "Link Index" page...
https://imgur.com/a/UJqJDVc
Eg:
First link i archived, the text link (the title of the page) is linked to :
https://*****/ArchiveBox/output/archive/1552560659/linuxconfig.org/allow-ssh-root-login-on-ubuntu-18-04-bionic-beaver-linux.html
Any subsequent archived pages, the text links like this :
https://******/ArchiveBox/output/archive/1552562637/index.html
@danmed commented on GitHub (Mar 14, 2019):
So, a bit more testing.. the problem seems to be that if i send it to a url with an index.html or index.php etc in the actual URL, it works great.. if the URL is just a folder.. then its not and it has this wierd behaviour..
good :
https://tylermade.net/2017/09/14/the-perfect-reverse-proxy-nginx-ssl-webui-management/index.php
bad:
https://tylermade.net/2017/09/14/the-perfect-reverse-proxy-nginx-ssl-webui-management/
@pirate commented on GitHub (Mar 15, 2019):
Oh yeah I've seen this bug before, I think I know how to fix it. Before I push anything though, do you mind confirming the git commit hash you're running so I can make sure you're on the latest master.
@danmed commented on GitHub (Mar 15, 2019):
Is this what you're after?
f0cf1772@pirate commented on GitHub (Mar 19, 2019):
Ok I think I fixed it in
61ec497. Can you try pulling the latest master and giving it a try.@danmed commented on GitHub (Mar 20, 2019):
Hmm i did a "git pull" but the problem is still there and the interface is
still showing " Archive created using ArchiveBox
https://github.com/pirate/ArchiveBox version
f0cf1772https://github.com/pirate/ArchiveBox/commit/f0cf17722b2f047f1bb5d69c6a16736e09c0ea03
"
what have i done wrong here?
On Tue, Mar 19, 2019 at 10:11 PM Nick Sweeting notifications@github.com
wrote:
@danmed commented on GitHub (Mar 20, 2019):
Ah nevermind.. looks like i needed to add a link for it to refresh the
page...seems to be working now! thanks!
On Wed, Mar 20, 2019 at 12:43 PM Dan Medhurst danmed@gmail.com wrote: