[PR #555] [MERGED] refactor: Move indexing logic out of logging module #1220

New issue

Closed

opened 2026-03-01 14:48:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:48:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/555
Author: @cdvv7788
Created: 11/28/2020
Status: ✅ Merged
Merged: 12/5/2020
Merged by: @pirate

Base: v0.5.0 ← Head: cleanup

📝 Commits (6)

fa5de72 refactor: Move indexing logic out of logging module
10ee6db lint: Remove unused variable
a846916 remove unused argument
648b4c8 feat: Remove unused function write_json_main_index
7008f9b feat: move import
00dfe2d Merge branch 'v0.5.0' into cleanup

📊 Changes

5 files changed (+42 additions, -65 deletions)

View changed files

📝 archivebox/index/__init__.py (+4 -4)
📝 archivebox/index/html.py (+8 -0)
📝 archivebox/index/json.py (+15 -26)
📝 archivebox/logging_util.py (+0 -32)
📝 archivebox/main.py (+15 -3)

📄 Description

Summary

Code was moved to places that made more sense according to its function

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/555 **Author:** [@cdvv7788](https://github.com/cdvv7788) **Created:** 11/28/2020 **Status:** ✅ Merged **Merged:** 12/5/2020 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `v0.5.0` ← **Head:** `cleanup` --- ### 📝 Commits (6) - [`fa5de72`](https://github.com/ArchiveBox/ArchiveBox/commit/fa5de72f9f9b371d0604e7721a7431414819b574) refactor: Move indexing logic out of logging module - [`10ee6db`](https://github.com/ArchiveBox/ArchiveBox/commit/10ee6db02f04f2516d4456d3bf31edbdc7574734) lint: Remove unused variable - [`a846916`](https://github.com/ArchiveBox/ArchiveBox/commit/a846916b82735a0a965e35ab7b518d3cef2052d5) remove unused argument - [`648b4c8`](https://github.com/ArchiveBox/ArchiveBox/commit/648b4c8aabfe69932083240f6d688ccc99ae023f) feat: Remove unused function `write_json_main_index` - [`7008f9b`](https://github.com/ArchiveBox/ArchiveBox/commit/7008f9b735c58d5189ea77f611b5d9c39950b109) feat: move import - [`00dfe2d`](https://github.com/ArchiveBox/ArchiveBox/commit/00dfe2d4499056a92e599889b4ff832e880f8c46) Merge branch 'v0.5.0' into cleanup ### 📊 Changes **5 files changed** (+42 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/index/__init__.py` (+4 -4) 📝 `archivebox/index/html.py` (+8 -0) 📝 `archivebox/index/json.py` (+15 -26) 📝 `archivebox/logging_util.py` (+0 -32) 📝 `archivebox/main.py` (+15 -3) </details> ### 📄 Description # Summary Code was moved to places that made more sense according to its function # Changes these areas - [ ] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [X] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>