[PR #517] [MERGED] fix: CHROME_USER_DATA_DIR #1202

Closed
opened 2026-03-01 14:48:50 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/517
Author: @cdvv7788
Created: 10/29/2020
Status: Merged
Merged: 10/29/2020
Merged by: @pirate

Base: masterHead: fix_chrome_user_data_dir_check


📝 Commits (2)

  • 81dd626 fix: CHROME_USER_DATA_DIR was causing an error after the update to posix paths
  • 1e5fbf4 Update archivebox/config/init.py

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 archivebox/config/__init__.py (+1 -1)

📄 Description

Summary

archivebox config --set CHROME_USER_DATA_DIR="./test" is causing an error after the update to posix paths. It raises:

   if 'Default' in config['CHROME_USER_DATA_DIR']:
TypeError: argument of type 'PosixPath' is not iterable

Related issues

#516

Changes these areas

  • Bugfixes
  • Feature behavior
  • Command line interface
  • Configuration options
  • Internal architecture
  • Snapshot data layout on disk

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/517 **Author:** [@cdvv7788](https://github.com/cdvv7788) **Created:** 10/29/2020 **Status:** ✅ Merged **Merged:** 10/29/2020 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `master` ← **Head:** `fix_chrome_user_data_dir_check` --- ### 📝 Commits (2) - [`81dd626`](https://github.com/ArchiveBox/ArchiveBox/commit/81dd626b85fe426ce558bc21481354acda2290f1) fix: CHROME_USER_DATA_DIR was causing an error after the update to posix paths - [`1e5fbf4`](https://github.com/ArchiveBox/ArchiveBox/commit/1e5fbf4bd2f38f420ee692727c006923d743049d) Update archivebox/config/__init__.py ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/config/__init__.py` (+1 -1) </details> ### 📄 Description # Summary `archivebox config --set CHROME_USER_DATA_DIR="./test"` is causing an error after the update to posix paths. It raises: ``` if 'Default' in config['CHROME_USER_DATA_DIR']: TypeError: argument of type 'PosixPath' is not iterable ``` # Related issues #516 # Changes these areas - [X] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 14:48:50 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ArchiveBox#1202
No description provided.