[GH-ISSUE #171] pdf? #120

New issue

Closed

opened 2026-03-01 14:40:46 +03:00 by kerem · 2 comments

kerem commented

2026-03-01 14:40:46 +03:00

Owner

Originally created by @g-mc on GitHub (Mar 11, 2019).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/171

github.com/pirate/ArchiveBox@32c39d0fd0/archivebox/util.py (L368-L370)

Is it necessary to have 'pdf' in Line 370?

Originally created by @g-mc on GitHub (Mar 11, 2019). Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/171 https://github.com/pirate/ArchiveBox/blob/32c39d0fd062738b23cf8c45164996f1c4b467f0/archivebox/util.py#L368-L370 Is it necessary to have `'pdf'` in Line 370?

kerem closed this issue

2026-03-01 14:40:46 +03:00

kerem commented

2026-03-01 14:40:47 +03:00

Author

Owner

@pirate commented on GitHub (Mar 11, 2019):

I'm removing get_link_type entirely in the next release, so this code will all dissapear. It's only being used in one place anyway right now, and that can be refactored out with better use of derived_link_info(), but thanks anyway for the code review!

@pirate commented on GitHub (Mar 11, 2019): I'm removing `get_link_type` entirely in the next release, so this code will all dissapear. It's only being used in one place anyway right now, and that can be refactored out with better use of `derived_link_info()`, but thanks anyway for the code review!

kerem commented

2026-03-01 14:40:47 +03:00

Author

Owner

@g-mc commented on GitHub (Mar 11, 2019):

No problem, thanks for the explanation! I’ve been enjoying reading through
the code just to try and understand how it all works!

Thanks for your time!

On Mon, Mar 11, 2019 at 2:07 AM Nick Sweeting notifications@github.com
wrote:

Closed #171 https://github.com/pirate/ArchiveBox/issues/171.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pirate/ArchiveBox/issues/171#event-2193104525, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AdiD1HHlz4Nhrmpbj9qPNtOaYMublvMzks5vVg7YgaJpZM4bnrwI
.

@g-mc commented on GitHub (Mar 11, 2019): No problem, thanks for the explanation! I’ve been enjoying reading through the code just to try and understand how it all works! Thanks for your time! On Mon, Mar 11, 2019 at 2:07 AM Nick Sweeting <notifications@github.com> wrote: > Closed #171 <https://github.com/pirate/ArchiveBox/issues/171>. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/pirate/ArchiveBox/issues/171#event-2193104525>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AdiD1HHlz4Nhrmpbj9qPNtOaYMublvMzks5vVg7YgaJpZM4bnrwI> > . >

kerem referenced this issue

2026-03-01 14:40:54 +03:00

[GH-ISSUE #191] Add support for recursive archiving of entire domains, or across domains to a given depth (using a crawler) #133

kerem referenced this issue

2026-03-01 17:52:27 +03:00

[GH-ISSUE #191] Add support for recursive archiving of entire domains, or across domains to a given depth (using a crawler) #1643

kerem referenced this issue

2026-03-14 21:17:41 +03:00

[GH-ISSUE #191] Add support for recursive archiving of entire domains, or across domains to a given depth (using a crawler) #3155