mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[PR #502] [MERGED] feat: Remove index.json and index.html generation #1195
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#1195
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/502
Author: @cdvv7788
Created: 10/8/2020
Status: ✅ Merged
Merged: 10/23/2020
Merged by: @cdvv7788
Base:
master← Head:remove-static-indexes📝 Commits (5)
3a5aa4bfeat: Remove index.json and index.html generation from the regular processffe180elint: Remove unused imports10d047drefactor: Update mentions of the html index in the logs3a3e554feat: Rename old indexes at the end of init processbc5c7bblint: Remove unused imports from utils📊 Changes
6 files changed (+39 additions, -39 deletions)
View changed files
📝
archivebox/index/__init__.py(+1 -13)📝
archivebox/logging_util.py(+4 -6)📝
archivebox/main.py(+10 -6)📝
tests/test_add.py(+15 -7)📝
tests/test_init.py(+6 -2)📝
tests/test_title.py(+3 -5)📄 Description
Summary
At the end of the
clicommands (add, remove, etc) the json and html indexes were still being generated. This is a slow process dependent on the number of archived links (size of the archive). This PR removes that generation, as they can be generated on demand using thearchivebox listcommand.**Related issues: #461
Changes these areas
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.